Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Resolve main executable symlink when looking up driver-adjacent subcommand binaries #1583

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

artemcm
Copy link
Contributor

@artemcm artemcm commented Apr 16, 2024

@artemcm
Copy link
Contributor Author

artemcm commented Apr 16, 2024

@swift-ci test

@artemcm artemcm requested a review from nkcsgexi April 16, 2024 19:49
Copy link
Contributor

@nkcsgexi nkcsgexi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@artemcm artemcm merged commit 950fc1e into swiftlang:main Apr 25, 2024
3 checks passed
@artemcm artemcm deleted the ResolveSymlinksForSubcommand branch April 25, 2024 21:57
@stevapple
Copy link
Contributor

I'm afraid this would break Windows support. IIRC we were using findExecutable for both cases because it can handle the executable suffix for us.

@kkebo
Copy link

kkebo commented Apr 27, 2024

@artemcm Do you plan to cherry-pick this to release/6.0?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

The new swift-driver doesn't seem to work properly when it's used through a symbolic link
4 participants