Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[5.10] Fix symbol link parsing bug for disambiguated subtraction operators #750

Conversation

d-ronnqvist
Copy link
Contributor

Cherry-pick of #739

  • Explanation: A link parsing inconsistency led to subtraction operators (-(_:_:)) not being findable if link had hash disambiguation but findable if it redundantly specified both the kind (-func.op) and the hash -abc123.
  • Scope: Parsing of authored DocC symbol links.
  • Issue: rdar://118234516
  • Risk: Low.
  • Testing: Added tests that both verify the specific parsing behavior and that verifies that such links resolve to the expected symbol when encountered in content.
  • Reviewer: @patshaughnessy

@d-ronnqvist
Copy link
Contributor Author

@swift-ci please test

@d-ronnqvist d-ronnqvist merged commit 2dd8c9c into swiftlang:release/5.10 Nov 14, 2023
2 checks passed
@d-ronnqvist d-ronnqvist deleted the minus-operator-disambiguation-parsing-5.10 branch November 14, 2023 14:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants