Backport async support to 5.5, PR #2 #336
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test <3 |
Tests/Functional/.lit_test_times.txt
Outdated
| @@ -0,0 +1,25 @@ | |||
| 1.238145e+01 Performance/main.swift | |||
There was a problem hiding this comment.
I don't think we want to include this file, do we? The other PR included a change to a .gitignore file to ignore this… Should we merge these two back-porting PRs into one so the .gitignore change will take effect also?
There was a problem hiding this comment.
Did I accidentally commit this? I'm sorry, this wasn't meant to be added.
briancroom
force-pushed
the
chefski/backport-async-support-to-5.5-windows-fix
branch
from
6d77f27 to
d35b428
Compare
|
@swift-ci please test |
Disable this test on Windows as this is exposing a latent UB in the Concurrency runtime. It seems better to safely disable this test on Windows for the time being until the runtime is fixed.
Allow passing through `-sdk %SDKROOT%` on Windows for tests.
briancroom
force-pushed
the
chefski/backport-async-support-to-5.5-windows-fix
branch
from
d35b428 to
f9722e6
Compare
|
@swift-ci please test |
|
Alright, I just cleaned this up a little bit to cleanly target |
stmontgomery
approved these changes
Nov 17, 2021
briancroom
approved these changes
Nov 17, 2021
|
Thank you! |
briancroom
deleted the
chefski/backport-async-support-to-5.5-windows-fix
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This includes a set of changes that @compnerd landed. We're back porting these to 5.5 so more users can take advantage of
async/awaitin XCTest.