-
Notifications
You must be signed in to change notification settings - Fork 284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement server-side support for inlay hints using CollectVariableType #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Query VariableTypeInfos from sourcekitd and return inlay hints for all variable declarations without an explicit type annotation.
The annotations are now (correctly) displayed after the variable identifiers rather than after the bound expressions.
fwcd
force-pushed
the
inlay-hints-collect-var-type
branch
from
June 24, 2021 16:52
7dcdd06
to
7eb2fae
Compare
I have tested this branch with the newest toolchain and it's looking pretty nice already: There are still two minor issues that probably have to be addressed on the SourceKit-side:
|
ahoppen
approved these changes
Jun 29, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
@swift-ci Please test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an early draft of support for inlay hints that uses the new
CollectVariableType
SourceKit request.Implementation Progress
CollectVariableType
CollectVariableType
requestsCollectVariableType