This repository has been archived by the owner on Jan 14, 2021. It is now read-only.
Load gif from asset catalog #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @tanukiti1987, thanks for the PR! Can you merge master into this branch to make sure the tests pass? |
tanukiti1987
force-pushed
the
laod_from_assets_catalog
branch
from
c0d0be0
to
910b1b1
Compare
|
Thank you for your checking! So can you check it again? |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
related. #66
Usually we're put image resources on assets catalog.
So if SwiftGif can load gif from there, it's more useful.
Can you check This PR? @bahlo
If you accept this PR, I'd like to use this feature on new library version :)