Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Menu bar item should support actions (href, bash, refresh) #110

Closed
bilal-fazlani opened this issue Dec 26, 2020 · 3 comments
Closed

Menu bar item should support actions (href, bash, refresh) #110

bilal-fazlani opened this issue Dec 26, 2020 · 3 comments
Assignees
@melonamin
Labels
enhancement New feature or request
Milestone
1.2.0

Comments

@bilal-fazlani
Copy link
Contributor

This is my example plugin

#!/bin/bash

echo "hi | href=https://google.com"

In BitBar the behaviour is when I click on "hi", it opens the link.
In SwiftBar, it doesn't.

Same of bash param.

href and bash both work only when they are in dropdown.

I think the BitBar behaviour is correct because it allows creating plugins which don't need a dropdown.
@bilal-fazlani bilal-fazlani changed the title Top level menu items Top level menu items don't respect href and bash Dec 26, 2020
@melonamin
Copy link
Contributor

Been mentioned here as well #101

@bilal-fazlani
Copy link
Contributor Author

Ooops, sorry for the duplicate

melonamin added a commit that referenced this issue Dec 26, 2020
@melonamin
Adding support for menu bar item actions #110
94d5fce
@melonamin
Copy link
Contributor

No worries, I needed an issue anyway.

@melonamin melonamin self-assigned this Dec 26, 2020
@melonamin melonamin added the enhancement New feature or request label Dec 26, 2020
@melonamin melonamin added this to the 1.2.0 milestone Dec 26, 2020
@melonamin melonamin changed the title Top level menu items don't respect href and bash Menu bar item should support actions (href, bash, refresh) Dec 26, 2020
This was referenced Jan 1, 2021
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@melonamin melonamin

Labels
enhancement New feature or request
Projects
None yet
Milestone
1.2.0
Development

No branches or pull requests
2 participants
@melonamin @bilal-fazlani