Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to NIOExtras HTTP Types Conversion #18

Merged
merged 1 commit into from
Apr 9, 2024
Merged

Migrate to NIOExtras HTTP Types Conversion #18

merged 1 commit into from
Apr 9, 2024

Conversation

0xTim
Copy link
Member

@0xTim 0xTim commented Apr 9, 2024

Swift NIO Extras now exposes conversions between NIO HTTP Types and Swift HTTP Types so we should use that instead of rolling our own.

Resolves #17

@0xTim 0xTim requested a review from MahdiBM as a code owner April 9, 2024 11:43
Copy link
Collaborator

@MahdiBM MahdiBM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👌

@0xTim 0xTim merged commit b53c151 into main Apr 9, 2024
2 checks passed
@0xTim 0xTim deleted the nio-http-types branch April 9, 2024 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use NIOHTTP1 to HTTPTypes conversion code in swift-nio-extras
2 participants