Fix crash for large HTTP request headers #661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Motivation We currently don't handle large headers well which trigger a channel writability change event. Modification Add failing (but currently skipped) tests which reproduces the issue Result We can reliably reproduce the large request header issue in an integration and unit test. Note that the actual fix is not included to make reviewing easier and will come in a follow up PR.
Fix crash for when sending HTTP request headers result in a channel writability change event
# Conflicts: # Sources/AsyncHTTPClient/ConnectionPool/HTTP1/HTTP1ClientChannelHandler.swift # Sources/AsyncHTTPClient/ConnectionPool/HTTP1/HTTP1Connection.swift # Tests/AsyncHTTPClientTests/HTTPClientTests+XCTest.swift # Tests/AsyncHTTPClientTests/HTTPClientTests.swift
# Conflicts: # Tests/AsyncHTTPClientTests/HTTP2ClientRequestHandlerTests.swift # Tests/AsyncHTTPClientTests/HTTPClientTests.swift
Lukasa
reviewed
Jan 27, 2023
|
|
||
| self.request!.requestHeadSent() |
There was a problem hiding this comment.
Why is this force-unwrap safe?
|
|
||
| self.request!.requestHeadSent() | ||
| if resumeRequestBodyStream { | ||
| self.request!.resumeRequestBodyStream() |
There was a problem hiding this comment.
Relatedly, why is this safe? Can it end up nil after the preceding outcall?
There was a problem hiding this comment.
Great catch! This is not safe. I added a test which crashed previously bit is fixed by chaining the implantation to unwrap safely: 18f6505
Sources/AsyncHTTPClient/ConnectionPool/HTTP2/HTTP2ClientRequestHandler.swift
Show resolved
Hide resolved
|
@swift-server-bot test this please |
Lukasa
approved these changes
Feb 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
Fixes tests added in #658 and #659
Modification
Gracefully handle writability change events while headers are send.
Result
Large headers can be send. This could actually happen randomly for small headers too, especially in the HTTP/2 case. They just need to fill the buffer and trigger back pressure.