Skip to content

Commit

Permalink
Add support of ephemeral-storage resource definition for opentelemetr…
Browse files Browse the repository at this point in the history
…y-operator (open-telemetry#1170)

* Allowed ephemeral storage to operator

* Resolve chart version conflicts

* Bump version

* Added key and comments

* Revert changes in crd

* fix spaces

* Disable ephemeral-storage by default
  • Loading branch information
jdiegosierra authored May 16, 2024
1 parent aaa70bd commit f32c273
Show file tree
Hide file tree
Showing 14 changed files with 40 additions and 20 deletions.
2 changes: 1 addition & 1 deletion charts/opentelemetry-operator/Chart.yaml
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
apiVersion: v2
name: opentelemetry-operator
version: 0.58.0
version: 0.58.1
description: OpenTelemetry Operator Helm chart for Kubernetes
type: application
home: https://opentelemetry.io/
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
annotations:
cert-manager.io/inject-ca-from: default/example-opentelemetry-operator-serving-cert
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand Down Expand Up @@ -91,7 +91,7 @@ metadata:
annotations:
cert-manager.io/inject-ca-from: default/example-opentelemetry-operator-serving-cert
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: cert-manager.io/v1
kind: Certificate
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand All @@ -30,7 +30,7 @@ apiVersion: cert-manager.io/v1
kind: Issuer
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand Down Expand Up @@ -223,7 +223,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand All @@ -242,7 +242,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRole
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand All @@ -26,7 +26,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: ClusterRoleBinding
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: apps/v1
kind: Deployment
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: Role
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: rbac.authorization.k8s.io/v1
kind: RoleBinding
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ apiVersion: v1
kind: Service
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand Down Expand Up @@ -32,7 +32,7 @@ apiVersion: v1
kind: Service
metadata:
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
name: opentelemetry-operator
namespace: default
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
name: "example-opentelemetry-operator-cert-manager"
namespace: default
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ metadata:
name: "example-opentelemetry-operator-metrics"
namespace: default
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand Down Expand Up @@ -44,7 +44,7 @@ metadata:
name: "example-opentelemetry-operator-webhook"
namespace: default
labels:
helm.sh/chart: opentelemetry-operator-0.58.0
helm.sh/chart: opentelemetry-operator-0.58.1
app.kubernetes.io/name: opentelemetry-operator
app.kubernetes.io/version: "0.99.0"
app.kubernetes.io/managed-by: Helm
Expand Down
16 changes: 16 additions & 0 deletions charts/opentelemetry-operator/values.schema.json
Original file line number Diff line number Diff line change
Expand Up @@ -555,6 +555,14 @@
"examples": [
"128Mi"
]
},
"ephemeral-storage": {
"type": "string",
"default": "",
"title": "The ephemeral-storage Schema",
"examples": [
"50Mi"
]
}
},
"examples": [{
Expand Down Expand Up @@ -587,6 +595,14 @@
"examples": [
"64Mi"
]
},
"ephemeral-storage": {
"type": "string",
"default": "",
"title": "The ephemeral-storage Schema",
"examples": [
"50Mi"
]
}
},
"examples": [{
Expand Down
6 changes: 5 additions & 1 deletion charts/opentelemetry-operator/values.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -80,9 +80,11 @@ manager:
limits:
cpu: 100m
memory: 128Mi
# ephemeral-storage: 50Mi
requests:
cpu: 100m
memory: 64Mi
# ephemeral-storage: 50Mi
## Adds additional environment variables
## e.g ENV_VAR: env_value
env:
Expand Down Expand Up @@ -138,17 +140,19 @@ manager:
# Enable vertical pod autoscaler support for the manager
verticalPodAutoscaler:
enabled: false
# List of resources that the vertical pod autoscaler can control. Defaults to cpu and memory
# List of resources that the vertical pod autoscaler can control. Defaults to cpu, memory and ephemeral-storage.
controlledResources: []

# Define the max allowed resources for the pod
maxAllowed: {}
# cpu: 200m
# memory: 100Mi
# ephemeral-storage: 50Mi
# Define the min allowed resources for the pod
minAllowed: {}
# cpu: 200m
# memory: 100Mi
# ephemeral-storage: 50Mi

updatePolicy:
# Specifies whether recommended updates are applied when a Pod is started and whether recommended updates
Expand Down

0 comments on commit f32c273

Please sign in to comment.