Accepting DateTimeInterface for Date and DateTime Literals (foreign code by @madbob). #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Author: @madbob Source: https://github.com/madbob/easyrdf/tree/datetimeinterface Added/made a few refinements (coding styles, PHPStan related)
when using PHP 7.1 or below, constant ATOM is not available for DateTimeInterface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@madbob: I found your pull request for EasyRdf with DateTimeInterface very useful and therefore cherry picked it for my fork.
Changes:
assertNullon$literal->getLang(). Replaced it withassertStringEquals.\DateTimeInterface::ATOMwhen using PHP 7.1 or below.