-
Notifications
You must be signed in to change notification settings - Fork 50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support sweetalert2 v8 #72
Conversation
Since supporting edit: see issue #73 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yay! 🎉
Just one more commit to add: since the new
Swal.update
static method is not supported yet, I think calling it should throw an error. @limonte any thoughts?
I don't have any strong opinion here, please go ahead with whatever you think is the better way.
This reverts commit 504d149.
71648d3
to
bf52a4e
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
With jest v24 and sweetalert2@^8.3.0 the CI build is passing 🚀
@zenflow please remove WIP and merge the PR if you think it's good to go
I would like to resolve issue #82/#83 (same issue) before attempting/making this release, but unfortunately work has been demanding more of my time lately, and this will continue for at least another few weeks. @gverni if you have time and are keen on it (which you generally seem to be for Swal2 😃), would you like to resolve issue #82/#83 and see this PR across the finish line? Aside from that issue, I think this PR is ready to be merged and released |
🎉 This PR is included in version 1.1.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Closes #66
No changes to the source code were actually needed to get the tests passing; just needed to stop some removed features in the
cleanSwalState
test utility function.Note that this PR keeps support for v7, but in the next major release I think we should drop it.
We should merge this with commit message
feat(package): support sweetalert2 v8
. The changes are backwards-compatible so we can make it a minor release.Just one more commit to add: since the new
Swal.update
static method is not supported yet, I think calling it should throw an error. @limonte any thoughts?