fix: drop legacy hooks

sweetalert2 · May 19, 2021 · a736204 · a736204
1 parent b4b94d5
commit a736204
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 3 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -12,7 +12,7 @@ jobs:
     runs-on: ubuntu-latest
 
     steps:
-    - uses: actions/checkout@v1
+    - uses: actions/checkout@v2
 
     - name: Install npm dependencies
       run: yarn install

diff --git a/src/index.js b/src/index.js
@@ -31,15 +31,15 @@ export default function withReactContent (ParentSwal) {
 
           let domElement
 
-          const openHookName = params.onOpen || !ParentSwal.isValidParameter('didOpen') ? 'onOpen' : 'didOpen' // support legacy onOpen hook
+          const openHookName = 'didOpen'
           const superOpenHook = params[openHookName] || noop
           params[openHookName] = (element) => {
             domElement = getter(ParentSwal)
             domElement && ReactDOM.render(reactElement, domElement)
             superOpenHook(element)
           }
 
-          const destroyHookName = params.onDestroy || !ParentSwal.isValidParameter('didDestroy') ? 'onDestroy' : 'didDestroy' // support legacy onDestroy hook
+          const destroyHookName = 'didDestroy'
           const superDestroyHook = params[destroyHookName] || noop
           params[destroyHookName] = (element) => {
             superDestroyHook(element)