This repository has been archived by the owner on May 19, 2023. It is now read-only.
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
swc-windows-installer.py: Install GNU Make from gnuwin32
The Make binary in msysGit doesn't work with the MSys2-based Git for Windows, raising [1]: The program can't start because msys-1.0.dll is missing from your computer. The gnuwin32 [2] binaries are built from GNU Make v3.81 (2006-04-01 [3]), but they run without crashing [4]. We need the dependencies to avoid [5]: The program can't start because libintl3.dll is missing from your computer. Somewhat suspicously, the MD5 digest of the dependencies I got from SourceForge (2edb5b27ab0818b727fb43494dc40a5f) doesn't match the MD5 digest listed on [2] (d370415aa924fa023411c4099ef84563). The size is the same though (708206 bytes), so I'm guessing the gnuwin32 listing is just stale. I downloaded the dependency zip from several SourceForge mirrors using several hosts, and always got the same digests, so if the hash-mismatch is malicious, the attacker is doing a good job ;). I also updated zip_install to take an optional 'path' argument, so we can unpack several zips to the same directory (without it, we'd get the "existing installation" message for the second zip). _MakeDirsError works around the change in makedirs errors between Python 2 [6] and Python 3 [7]. [1]: #34 (comment) [2]: http://gnuwin32.sourceforge.net/packages/make.htm [3]: http://git.savannah.gnu.org/cgit/make.git/tag/?id=3.81 [4]: #34 (comment) [5]: #35 (comment) [6]: https://docs.python.org/2/library/os.html#os.makedirs [7]: https://docs.python.org/3/library/os.html#os.makedirs
- Loading branch information