-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(typescript): Align isolatedDeclaration
implementation with tsc
#9715
base: main
Are you sure you want to change the base?
Conversation
|
thanks for your help❤️️ 😂 got another blocking point of isolatedDeclaration should generate the same error as tsc
I'll open another issue |
CodSpeed Performance ReportMerging #9715 will improve performances by 9.3%Comparing Summary
Benchmarks breakdown
|
isolatedDeclaration
isolatedDeclaration
isolatedDeclaration
implementation with tsc
isolatedDeclaration
implementation with tscisolatedDeclaration
implementation with tsc
76f6050
to
49c2be0
Compare
49c2be0
to
533853e
Compare
Description:
Most code is direct translation of https://github.com/oxc-project/oxc/tree/main/crates/oxc_isolated_declarations. The differences come from:
tsc --declaration --isolatedDeclarations --emitDeclarationOnly --isolatedModules --noResolve --noCheck --strictNullChecks test.ts
BREAKING CHANGE:
It will change most of the generated results of
d.ts
.Related issue (if exists):
closes #9705
closes #9718