Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf(es/compat): Reimplement constructor transform #9519

Merged
merged 7 commits into from
Sep 2, 2024

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari commented Aug 31, 2024

Copy link

changeset-bot bot commented Aug 31, 2024

🦋 Changeset detected

Latest commit: 5a6a908

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link

socket-security bot commented Aug 31, 2024

🚨 Potential security issues detected. Learn more about Socket for GitHub ↗︎

To accept the risk, merge this PR and you will not be notified again.

Alert Package NoteSourceCI
Critical CVE npm/[email protected] ⚠︎

View full report↗︎

Next steps

What is a critical CVE?

Contains a Critical Common Vulnerability and Exposure (CVE).

Remove or replace dependencies that include known critical CVEs. Consumers can use dependency overrides or npm audit fix --force to remove vulnerable dependencies.

Take a deeper look at the dependency

Take a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev.

Remove the package

If you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency.

Mark a package as acceptable risk

To ignore an alert, reply with a comment starting with @SocketSecurity ignore followed by a space separated list of ecosystem/package-name@version specifiers. e.g. @SocketSecurity ignore npm/[email protected] or ignore all packages with @SocketSecurity ignore-all

Copy link

codspeed-hq bot commented Aug 31, 2024

CodSpeed Performance Report

Merging #9519 will degrade performances by 5.31%

Comparing magic-akari:refactor/class-constructor (5a6a908) with main (f584ef7)

Summary

⚡ 2 improvements
❌ 1 regressions
✅ 175 untouched benchmarks

⚠️ Please fix the performance issues or acknowledge them on CodSpeed.

Benchmarks breakdown

Benchmark main magic-akari:refactor/class-constructor Change
es/full/bugs-1 574 µs 514.6 µs +11.54%
es/full/codegen/es2015 275.5 µs 290.9 µs -5.31%
es2015_classes 407.6 µs 392.5 µs +3.84%

@magic-akari magic-akari changed the title refactor(es/compat): Reimplement constructor transform perf(es/compat): Reimplement constructor transform Sep 1, 2024
@magic-akari magic-akari marked this pull request as ready for review September 1, 2024 04:08
@magic-akari magic-akari requested review from a team as code owners September 1, 2024 04:08
@kdy1 kdy1 added this to the Planned milestone Sep 1, 2024
Copy link

socket-security bot commented Sep 1, 2024

Report too large to display inline

View full report↗︎

@magic-akari
Copy link
Member Author

This pull request updates @swc/helpers; the version should be incremented upon release.

Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sw

@kdy1 kdy1 merged commit 4b85a92 into swc-project:main Sep 2, 2024
155 checks passed
@magic-akari magic-akari deleted the refactor/class-constructor branch September 2, 2024 11:21
@kdy1 kdy1 modified the milestones: Planned, v1.7.23 Sep 2, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 3, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

Inconsistent conversion output of class
2 participants