Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/typescrupt): Fix ASI issue in fast ts strip #9332

Merged
merged 7 commits into from
Jul 25, 2024

Conversation

magic-akari
Copy link
Member

Related issue (if exists):

@magic-akari magic-akari requested a review from a team as a code owner July 24, 2024 19:09
Copy link

changeset-bot bot commented Jul 24, 2024

🦋 Changeset detected

Latest commit: d7d949d

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@magic-akari magic-akari marked this pull request as draft July 24, 2024 19:41
@magic-akari magic-akari marked this pull request as ready for review July 24, 2024 19:54
Copy link

codspeed-hq bot commented Jul 24, 2024

CodSpeed Performance Report

Merging #9332 will improve performances by 3.4%

Comparing magic-akari:fix/fast-ts-strip/asi (d7d949d) with magic-akari:fix/fast-ts-strip/asi (6d5f870)

Summary

⚡ 2 improvements
✅ 176 untouched benchmarks

Benchmarks breakdown

Benchmark magic-akari:fix/fast-ts-strip/asi magic-akari:fix/fast-ts-strip/asi Change
es/full/bugs-1 553 µs 535.9 µs +3.18%
es/visitor/base-perf/boxing_unboxed_clone 2.7 µs 2.6 µs +3.4%

@kdy1 kdy1 added this to the Planned milestone Jul 25, 2024
@kdy1 kdy1 self-assigned this Jul 25, 2024
kdy1
kdy1 previously approved these changes Jul 25, 2024
@kdy1 kdy1 merged commit 57146cf into swc-project:main Jul 25, 2024
4 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.7.2 Jul 25, 2024
@magic-akari magic-akari deleted the fix/fast-ts-strip/asi branch July 31, 2024 12:44
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

@swc/wasm-typescript ASI risk
2 participants