Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(bindings/wasm): Shrink the size of the wasm file #9191

Merged
merged 3 commits into from
Jul 10, 2024
Merged

perf(bindings/wasm): Shrink the size of the wasm file #9191

merged 3 commits into from
Jul 10, 2024

Conversation

magic-akari
Copy link
Member

Description:

For binding_typescript_wasm, it reduces the WASM size by 48% .

BREAKING CHANGE:

Related issue (if exists):

@magic-akari magic-akari requested a review from a team as a code owner July 10, 2024 06:00
kdy1
kdy1 approved these changes Jul 10, 2024
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • dbg-swc

@kdy1 kdy1 added this to the Planned milestone Jul 10, 2024
@kdy1 kdy1 self-assigned this Jul 10, 2024
@kdy1 kdy1 changed the title perf: Shrink the size of the wasm file perf(bindings/wasm): Shrink the size of the wasm file Jul 10, 2024
@kdy1 kdy1 enabled auto-merge (squash) July 10, 2024 06:20
swc-bot
swc-bot reviewed Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

swc-bot
swc-bot reviewed Jul 10, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 3a23b3d into swc-project:main Jul 10, 2024
150 of 151 checks passed
kdy1 pushed a commit to kdy1/swc that referenced this pull request Jul 10, 2024
@magic-akari @kdy1
perf(bindings/wasm): Shrink the size of the wasm file (swc-project#9191)
22fded4
@magic-akari magic-akari deleted the wasm branch July 12, 2024 15:41
kdy1 added a commit that referenced this pull request Jul 12, 2024
@kdy1
Revert "perf(bindings/wasm): Shrink the size of the wasm file (#9191)"
85c4aad 
This reverts commit 3a23b3d.
@kdy1 kdy1 mentioned this pull request Jul 12, 2024
Merged
kdy1 added a commit that referenced this pull request Jul 12, 2024
@kdy1
perf(bindings): Invert Wasm size shrink (#9224)
aa7f791 
Reverts #9191

I'm reverting because it applies even to `@swc/core`. Instead, I used an environment variable.
@kdy1 kdy1 modified the milestones: Planned, v1.7.0 Jul 17, 2024
@Loonz806 Loonz806 mentioned this pull request Aug 8, 2024
Closed
@kdy1 kdy1 mentioned this pull request Aug 12, 2024
Merged
@Loonz806 Loonz806 mentioned this pull request Aug 15, 2024
Closed
@swc-project swc-project locked as resolved and limited conversation to collaborators Aug 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.7.0
Development

Successfully merging this pull request may close these issues.
3 participants
@magic-akari @kdy1 @swc-bot