Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/minifier): Fix typescript enum detection #9031

Merged
merged 2 commits into from
Jun 11, 2024

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 11, 2024

Description:

This reverts commit cc8c155 because it caused a regression in the next.js canary.

  • Canary version: 15.0.0-canary.12

Related issue:

@kdy1 kdy1 added this to the Planned milestone Jun 11, 2024
@kdy1 kdy1 self-assigned this Jun 11, 2024
@kdy1 kdy1 marked this pull request as ready for review June 11, 2024 05:37
@kdy1 kdy1 requested a review from a team as a code owner June 11, 2024 05:37
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.


swc-bump:

  • swc_ecma_minifier
  • swc_core

@kdy1 kdy1 enabled auto-merge (squash) June 11, 2024 05:38
@kdy1 kdy1 disabled auto-merge June 11, 2024 05:59
@kdy1 kdy1 merged commit 6669343 into swc-project:main Jun 11, 2024
140 of 148 checks passed
@kdy1 kdy1 deleted the revert-swc-core branch June 11, 2024 05:59
@kdy1 kdy1 modified the milestones: Planned, v1.5.28 Jun 11, 2024
kdy1 added a commit to vercel/turborepo that referenced this pull request Jun 11, 2024
### Description

Update `swc_core`. The regression of the minifier is fixed by swc-project/swc#9031


### Testing Instructions


- Closes vercel/next.js#66182
kdy1 added a commit to vercel/next.js that referenced this pull request Jun 11, 2024
# Turbopack

* vercel/turborepo#8324 <!-- Tobias Koppers - fix panic in debug mode -->
* vercel/turborepo#8395 <!-- Donny/강동윤 - build: Update `swc_core` to `v0.93.2` -->


### What?


Update `swc_core`. 

### Why?

Update `swc_core`. The regression of minifier is fixed by swc-project/swc#9031


### How?
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 11, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

1 participant