Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/compat): Support vars from reserved_word pass #8543

Merged
merged 7 commits into from
Jan 23, 2024
Merged

fix(es/compat): Support vars from reserved_word pass #8543

merged 7 commits into from
Jan 23, 2024
+98 −25

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jan 23, 2024

@kdy1 kdy1 added this to the Planned milestone Jan 23, 2024
@kdy1 kdy1 self-assigned this Jan 23, 2024
@kdy1 kdy1 requested a review from a team as a code owner January 23, 2024 03:02
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 23, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: a0292d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

kdy1
kdy1 commented Jan 23, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_compat_es3

@kdy1 kdy1 enabled auto-merge (squash) January 23, 2024 03:03
swc-bot
swc-bot reviewed Jan 23, 2024
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit fc929e9 into swc-project:main Jan 23, 2024
142 checks passed
@kdy1 kdy1 deleted the issue-8539 branch January 23, 2024 04:23
@kdy1 kdy1 modified the milestones: Planned, v1.3.106 Jan 24, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Feb 23, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.106
Development

Successfully merging this pull request may close these issues.

Exporting a variable called goto with env targets enabled results in it being renamed to _goto
2 participants
@kdy1 @swc-bot