fix(es/compat): Handle __proto__ edge case in shorthand pass
#8077
+110
−76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CI will fail, but some of them are not related to this PR and will be fixed by #8079 |
kdy1
reviewed
Oct 10, 2023
| *prop = Prop::KeyValue(KeyValueProp { | ||
| key: PropName::Ident(quote_ident!(*span, sym.clone())), | ||
| value: Box::new(quote_ident!(*span, sym.clone()).into()), | ||
| key: if ident.sym == js_word!("__proto__") { |
magic-akari
force-pushed
the
fix/shorthand
branch
from
9c6f2f4 to
cb6de7a
Compare
kdy1
approved these changes
Oct 10, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue:
__proto__properties babel/babel#12664