Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/codegen): Use emitAssertForImportAttributes #7936

Merged
merged 3 commits into from
Sep 11, 2023
Merged

fix(es/codegen): Use emitAssertForImportAttributes #7936

merged 3 commits into from
Sep 11, 2023
+14 −5

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Sep 11, 2023

Description:

  • Add format.emitAssertForImportAttributes to minify()
  • Use jsc.experimental. emitAssertForImportAttributes.

Related issue (if exists):

@kdy1 kdy1 added this to the Planned milestone Sep 11, 2023
@kdy1 kdy1 self-assigned this Sep 11, 2023
@kdy1 kdy1 marked this pull request as ready for review September 11, 2023 07:55
kodiakhq[bot]
kodiakhq bot previously approved these changes Sep 11, 2023
View reviewed changes
@kdy1 kdy1 enabled auto-merge (squash) September 11, 2023 07:55
kdy1
kdy1 commented Sep 11, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_codegen

@kdy1 kdy1 merged commit dac8888 into swc-project:main Sep 11, 2023
128 checks passed
@kdy1 kdy1 deleted the issue-7928 branch September 11, 2023 08:31
@kdy1 kdy1 modified the milestones: Planned, v1.3.85 Sep 11, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.84
Development

Successfully merging this pull request may close these issues.

emitAssertForImportAttributes does not emit assert for import attributes .swcrc is not used for JS minify()
1 participant
@kdy1