Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/compat): Support pure_getters for optional_chaining #7933

Merged
merged 2 commits into from
Sep 13, 2023
Merged

feat(es/compat): Support pure_getters for optional_chaining #7933

merged 2 commits into from
Sep 13, 2023
+567 −553

Conversation

Austaras
Copy link
Member

@Austaras Austaras commented Sep 10, 2023 •
edited by kdy1
Loading

@Austaras Austaras force-pushed the main branch 2 times, most recently from fe637b8 to 9dab099 Compare September 10, 2023 23:12
kdy1
kdy1 requested changes Sep 12, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge strip_with_config into stript?

@Austaras
Copy link
Member Author

I don't believe it would be easy. Both are referenced many times.

kdy1
kdy1 approved these changes Sep 13, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

swc-bump:

  • swc_ecma_transforms_compat

@kdy1 kdy1 self-assigned this Sep 13, 2023
@kdy1 kdy1 added this to the Planned milestone Sep 13, 2023
@kdy1 kdy1 enabled auto-merge (squash) September 13, 2023 02:03
@kdy1 kdy1 disabled auto-merge September 13, 2023 02:03
@kdy1 kdy1 changed the title feat(es/compat): impl pure_getters for optional_chaining feat(es/compat): Support pure_getters for optional_chaining Sep 13, 2023
@kdy1 kdy1 merged commit c091c5e into swc-project:main Sep 13, 2023
128 of 129 checks passed
@kdy1 kdy1 modified the milestones: Planned, v1.3.85 Sep 15, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Oct 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.85
Development

Successfully merging this pull request may close these issues.

Simple downlevelled optional chain generates an extra, unnecessary variable
2 participants
@Austaras @kdy1