-
-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(es/minifier): Don't inline properties if the var is not fn-local
#7839
Conversation
fn-local
I think we need to improve logic for |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
swc-bump:
- swc_ecma_minifier
Should we abort in the else block of this? It's causing many item being wrongfully inlined. For example export function createCaseFirst(g, methodName) {
var chr = g.get(0)
console.log(123)
return chr[methodName]() + trailing;
} In this case chr cannot be inlined because of side effects. |
I reflected it 👍 |
Description:
Related issue: