fix(testing): Use program as entry #7221
Conversation
| @@ -154,20 +154,20 @@ impl<'a> Tester<'a> { | |||
| name: &str, | |||
| syntax: Syntax, | |||
| src: &str, | |||
| ) -> Result<Module, ()> { | |||
| ) -> Result<Program, ()> { | |||
There was a problem hiding this comment.
Is this change necessary? I think we can alternatively change only the argument passed to fold_**
There was a problem hiding this comment.
I need to ensure that what fold_with is a program, so the return value has been changed to Program.
swc/crates/swc_ecma_transforms_testing/src/lib.rs
Lines 180 to 182 in 9fce494
convert back to Module might be difficult, as it is possible for it to be parsed as a script.
do you have some good ways to improve it?
There was a problem hiding this comment.
You mean you want to use parse_program?
If so, your code is the correct direction
There was a problem hiding this comment.
Yes, I want to use visit_mut_program.
If I get Module instead of Program, the visit_mut_program will be skipped.
See https://github.com/swc-project/swc/pull/7202/files#r1159484231
|
There are too many errors about Could you fix it? @kdy1 |
|
Of course, I'll do it tomorrow |
Description:
BREAKING CHANGE:
Related issue (if exists):
this issue block #7202