fix(ecma/codegen): don't print whitespaces for comments in minify mode #6465
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@kdy1 Sounds like bug on CI (maybe cache)? No bugs on |
kdy1
previously approved these changes
Nov 18, 2022
|
@kdy1 I really don't undestand when I run it locally it removes spaces (i.e. |
|
@kdy1 Can you remove CI cache for |
|
It's not problem of CI. |
|
@kdy1 But I think the problem is not on my side, if I remove whitespaces in tests it:
If I return whitespaces, it:
But I can do nothing with CI |
This reverts commit ac27afd.
kdy1
approved these changes
Nov 20, 2022
swc-bot
reviewed
Nov 20, 2022
alexander-akait
deleted the
fix-avoid-empty-spaces-for-comments-in-minify-mode
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
We don't need extra whitespace for comments when we print minified output
BREAKING CHANGE:
No
Related issue (if exists):
No