fix(swc/cli): correctly expose swcx entrypoint #3784
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR fixes entrypoint to
swcxbinary for npm. It was my incorrect understanding pointing to native binary (swcx.exefor example) creates symlink tonode_modules/.bin. This isn't ideal as it requires warm up node.js process, but it allows easier experiment.This doesn't mean we'll use this as permanent solution. We don't even have decided to use
@swc/coreas single pkg or use separate pkg for cli. It's something we'll need to think about.Also: if someone see
node_modules/.bindoesn't haveswcxproperly, it's likely due to npm/cli#4308. I confirmed when it comes to scoped pkg there's no binary entrypoint being created.Related issue (if exists):