feat(swc/cli): initial compile command implementation #3602
Conversation
|
|
||
| let dist_absolute_path = out_dir.absolutize()?; | ||
|
|
||
| // These are possible combinations between input to output dir. |
There was a problem hiding this comment.
This is note for the future what we'll need to support for the path calculation.
|
|
||
| files | ||
| .into_par_iter() | ||
| .try_for_each_with(cm, |compiler, file_path| { |
There was a problem hiding this comment.
I choose naive parallel iterator for processing files, maybe there's better / recommended practices?
There was a problem hiding this comment.
The parallel iterator is the most ideal one if we have a list of files to process.
| #[clap(name = "SWC", version)] | ||
| #[clap(global_setting(AppSettings::PropagateVersion))] | ||
| #[clap(global_setting(AppSettings::UseLongFormatForHelpSubcommand))] | ||
| #[clap(name = "SWC", version, propagate_version = true)] |
There was a problem hiding this comment.
https://epage.github.io/blog/2022/02/clap-31-a-step-towards-40/ and happy to see clap moving towards a modular approach.
| serde = { version = "1", features = ["derive"] } | ||
| serde_json = { version = "1", features = ["unbounded_depth"] } | ||
|
|
||
| [dependencies.path-absolutize] |
There was a problem hiding this comment.
Yes, this is not a complete solution but reasonably works well to cover some cases as far as I could check. Still, as written in path resolution logic I believe we'll need further improvement though.
| .filter(|e| { | ||
| extensions.iter().any(|ext| { | ||
| e.extension() | ||
| .map(|v| v.to_str().unwrap_or("").eq(ext)) |
There was a problem hiding this comment.
OsStr implements PartialEq<str>. (https://doc.rust-lang.org/stable/std/ffi/struct.OsStr.html#impl-PartialEq%3Cstr%3E)
You can do v == &**ext instead.
| let base = file_path | ||
| .parent() | ||
| .unwrap_or(&default) | ||
| .as_os_str() |
There was a problem hiding this comment.
I think .display().to_string() is better.
|
|
||
| files | ||
| .into_par_iter() | ||
| .try_for_each_with(cm, |compiler, file_path| { |
There was a problem hiding this comment.
The parallel iterator is the most ideal one if we have a list of files to process.
kwonoj
force-pushed
the
feat-cli-compile-files
branch
from
3019db0
to
50f06f6
Compare
Description:
We have
pluginsubcommand, now we can work on other subcommand. This is initial effort to port over@swc/cli's compilation command features undercompilesubcommand. It doesn't cover all of existing cli args yet, only covers most basic execution paths.There are a couple of challenges we need to deal in the future. First, output path calculation relates to the input. This is not unique to this cli, as we have known issues like #3028 already. However, it's something we need to take care of.
Second one is more tricky -
pluginoptions for the js-written plugins. Previously we can rely on node.js runtime as cli runs on those, which new cli doesn't. I don't have great idea yet except either deprecate js plugin or spin node.js separately to get transformed output from those. Both are not great.Related issue (if exists):