Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No more standalone binaries upload in release assets since 1.5.8 #9035

Closed
Klaitos opened this issue Jun 11, 2024 Discussed in #9034 · 3 comments · Fixed by #9040
Closed

No more standalone binaries upload in release assets since 1.5.8 #9035

Klaitos opened this issue Jun 11, 2024 Discussed in #9034 · 3 comments · Fixed by #9040
Assignees
Milestone

Comments

@Klaitos
Copy link

Klaitos commented Jun 11, 2024

Discussed in #9034

Originally posted by Klaitos June 11, 2024
Hello,
We were downloading swc binaries from Github in our CI to generate source maps.
Since v1.5.8, only .node files are uploaded and not executable on system anymore. Is this an expected behavior ?

Assets uploaded before :

  • swc-darwin-arm64

Assets now :

  • swc.darwin-arm64.node (little change in naming too after swc)

Thanks

@kdy1 kdy1 self-assigned this Jun 12, 2024
@kdy1 kdy1 added this to the Planned milestone Jun 12, 2024
kdy1 added a commit that referenced this issue Jun 12, 2024
@kdy1
Copy link
Member

kdy1 commented Jun 12, 2024

I triggered a nightly release with dab7bfc

I'll publish a normal version if the CI fix was correct and nightly publish action works as expected

@Klaitos
Copy link
Author

Klaitos commented Jun 12, 2024

Thanks

@kdy1 kdy1 modified the milestones: Planned, v1.5.29 Jun 13, 2024
@swc-bot
Copy link
Collaborator

swc-bot commented Jul 13, 2024

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.

@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 13, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging a pull request may close this issue.

3 participants