"private should be removed by class_properties" error when use preset_env

[zhangpanweb]

Describe the bug

When use preset_env to fold ast of using this.# and ||=, for examplethis.#a ||= 1, swc will panic at private should be removed by class_properties.

Discovery these after read the logic of swc:

• preset_env will use folder according to inner plugin.json data and target config.
• In Chrome 74, class_property have been natively implemented , see plugin.json . Therefore, it will not be used
• but logical_assignments depends on class_property. So it will run into the unreachable!("private should be removed by class_properties")

If change the target to chrome 73 or include class_property when use preset_env, the code will run as normal

Input code

fn main() {
    let source = r#"
    class A {
        b() {
            this.#a ||= 1;
        }
    }
"#;

    let cm: Lrc<SourceMap> = Default::default();
    let fm = cm.new_source_file(FileName::Real(Path::new("").to_owned()), source.to_owned());

    let lexer = Lexer::new(
        Syntax::Es(EsConfig {
            ..Default::default()
        }),
        swc_ecma_ast::EsVersion::default(),
        StringInput::from(&*fm),
        None,
    );

    let mut parser = Parser::new_from(lexer);

    let ast = parser.parse_module().unwrap();

    let globals = Globals::default();
    let targets: Targets = serde_json::from_str(r#"{"chrome":74}"#).unwrap();
    GLOBALS.set(&globals, || {
        let _ = try_with_handler(cm.clone(), Default::default(), |handler| {
            HELPERS.set(&Helpers::new(true), || {
                HANDLER.set(handler, || {
                    let mut preset_env = swc_ecma_preset_env::preset_env(
                        Mark::new(),
                        Some(NoopComments),
                        swc_ecma_preset_env::Config {
                            targets: Some(targets),
                            mode: Some(swc_ecma_preset_env::Mode::Entry),
                            ..Default::default()
                        },
                        Assumptions::default(),
                        &mut FeatureFlag::default(),
                    );
                    preset_env.fold_module(ast.clone());
                });
            });

            Ok(())
        });
    });
}

Config

No response

Playground link

https://github.com/zhangpanweb/swc-private-assign-error

SWC Info output

No response

Expected behavior

preset_env will work as normal, and not panic

Actual behavior

No response

Version

swc_common: 0.31.17

Additional context

No response

[swc-bot]

This closed issue has been automatically locked because it had no new activity for a month. If you are running into a similar issue, please create a new issue with the steps to reproduce. Thank you.