fix(es/compat): Skip function scope in block-scoped-fns pass (#7975)

**Related issue:**

 - Closes: #2793

crates/swc/tests/fixture/issues-2xxx/2793/input/.swcrc

@@ -0,0 +1,5 @@
+{
+    "jsc": {
+        "target": "es5"
+    }
+}

crates/swc/tests/fixture/issues-2xxx/2793/input/index.js

@@ -0,0 +1,34 @@
+function foo() {}
+
+function foo() {
+    function bar() {}
+}
+
+///////////////////
+{
+    function foo() {}
+}
+
+{
+    {
+        function foo() {}
+    }
+}
+
+if (true) {
+    function foo() {}
+}
+
+try {
+    function foo() {}
+} catch (e) {
+    function foo() {}
+} finally {
+    function foo() {}
+}
+
+switch (x) {
+    default: {
+        function foo() {}
+    }
+}

crates/swc/tests/fixture/issues-2xxx/2793/output/index.js

@@ -0,0 +1,27 @@
+function foo() {}
+function foo() {
+    function bar() {}
+}
+///////////////////
+{
+    var foo1 = function foo1() {};
+}{
+    {
+        var foo2 = function foo2() {};
+    }
+}if (true) {
+    var foo3 = function foo3() {};
+}
+try {
+    var foo4 = function foo4() {};
+} catch (e) {
+    var foo5 = function foo5() {};
+} finally{
+    var foo6 = function foo6() {};
+}
+switch(x){
+    default:
+        {
+            var foo7 = function foo7() {};
+        }
+}

crates/swc/tests/fixture/issues-3xxx/3417/1/output/index.ts

@@ -1,9 +1,9 @@
 export function selectRooms(building) {
-    var getRoomFloorMaterial = function getRoomFloorMaterial(_) {
-        return null;
-    };
     var roomsByRow = {};
     var rooms = building.rooms, walls = building.walls, levels = building.levels, roomsByLevel = building.roomsByLevel;
+    function getRoomFloorMaterial(_) {
+        return null;
+    }
     var _iteratorNormalCompletion = true, _didIteratorError = false, _iteratorError = undefined;
     try {
         var _loop = function() {

crates/swc/tests/fixture/issues-6xxx/6345/1/output/index.js

@@ -1,18 +1,18 @@
 "use strict";
 function a() {}
 var te = function() {
-    var n = function n(n) {};
+    function n(n) {}
     var t = null;
     return {
-        init: function r(r) {
-            return t = new n(r);
+        init: function u(u) {
+            return t = new n(u);
         }
     };
 }();
 var he = function() {
-    var n = function n() {
+    function n() {
         a();
-    };
+    }
     ;
     var t = null;
     return {

crates/swc/tests/tsc-references/ClassAndModuleThatMergeWithModuleMemberThatUsesClassTypeParameter.1.normal.js

@@ -6,7 +6,7 @@ var clodule1 = function clodule1() {
     _class_call_check(this, clodule1);
 };
 (function(clodule1) {
-    var f = function f(x) {};
+    function f(x) {}
 })(clodule1 || (clodule1 = {}));
 var clodule2 = function clodule2() {
     "use strict";

crates/swc/tests/tsc-references/ClassAndModuleThatMergeWithModulesExportedGenericFunctionAndGenericClassStaticFunctionOfTheSameName.1.normal.js

@@ -9,9 +9,9 @@ var clodule = /*#__PURE__*/ function() {
     return clodule;
 }();
 (function(clodule) {
-    var fn = function fn(x, y) {
+    function fn(x, y) {
         return x;
-    };
+    }
     // error: duplicate identifier expected
     clodule.fn = fn;
 })(clodule || (clodule = {}));

crates/swc/tests/tsc-references/ClassAndModuleThatMergeWithModulesExportedGenericFunctionAndNonGenericClassStaticFunctionOfTheSameName.1.normal.js

@@ -9,9 +9,9 @@ var clodule = /*#__PURE__*/ function() {
     return clodule;
 }();
 (function(clodule) {
-    var fn = function fn(x, y) {
+    function fn(x, y) {
         return x;
-    };
+    }
     // error: duplicate identifier expected
     clodule.fn = fn;
 })(clodule || (clodule = {}));

crates/swc/tests/tsc-references/ClassAndModuleThatMergeWithModulesExportedStaticFunctionUsingClassPrivateStatics.1.normal.js

@@ -11,9 +11,9 @@ var clodule = /*#__PURE__*/ function() {
     return clodule;
 }();
 (function(clodule) {
-    var fn = function fn(x, y) {
+    function fn(x, y) {
         return clodule.sfn("a");
-    };
+    }
     // error: duplicate identifier expected
     clodule.fn = fn;
 })(clodule || (clodule = {}));

crates/swc/tests/tsc-references/ClassAndModuleThatMergeWithStaticFunctionAndExportedFunctionThatShareAName.1.normal.js

@@ -17,10 +17,9 @@ var Point = /*#__PURE__*/ function() {
     return Point;
 }();
 (function(Point) {
-    var Origin = function Origin() {
+    function Origin() {
         return null;
     } //expected duplicate identifier error
-    ;
     Point.Origin = Origin;
 })(Point || (Point = {}));
 var A;
@@ -43,10 +42,9 @@ var A;
     }();
     A.Point = Point;
     (function(Point) {
-        var Origin = function Origin() {
+        function Origin() {
             return "";
         } //expected duplicate identifier error
-        ;
         Point.Origin = Origin;
     })(Point = A.Point || (A.Point = {}));
 })(A || (A = {}));

crates/swc/tests/tsc-references/ClassAndModuleThatMergeWithStaticFunctionAndNonExportedFunctionThatShareAName.1.normal.js

@@ -16,10 +16,9 @@ var Point = /*#__PURE__*/ function() {
     return Point;
 }();
 (function(Point) {
-    var Origin = function Origin() {
+    function Origin() {
         return "";
     } // not an error, since not exported
-    ;
 })(Point || (Point = {}));
 var A;
 (function(A) {
@@ -40,9 +39,8 @@ var A;
     }();
     A.Point = Point;
     (function(Point) {
-        var Origin = function Origin() {
+        function Origin() {
             return "";
         } // not an error since not exported
-        ;
     })(Point = A.Point || (A.Point = {}));
 })(A || (A = {}));

crates/swc/tests/tsc-references/ExportFunctionWithAccessibleTypesInParameterAndReturnTypeAnnotation.1.normal.js

@@ -2,12 +2,6 @@
 import { _ as _class_call_check } from "@swc/helpers/_/_class_call_check";
 var A;
 (function(A) {
-    var fromOrigin = function fromOrigin(p) {
-        return new Line({
-            x: 0,
-            y: 0
-        }, p);
-    };
     var Point = function Point() {
         "use strict";
         _class_call_check(this, Point);
@@ -20,5 +14,11 @@ var A;
         this.end = end;
     };
     A.Line = Line;
+    function fromOrigin(p) {
+        return new Line({
+            x: 0,
+            y: 0
+        }, p);
+    }
     A.fromOrigin = fromOrigin;
 })(A || (A = {}));

crates/swc/tests/tsc-references/ExportFunctionWithInaccessibleTypesInParameterTypeAnnotation.1.normal.js

@@ -2,12 +2,6 @@
 import { _ as _class_call_check } from "@swc/helpers/_/_class_call_check";
 var A;
 (function(A) {
-    var fromOrigin = function fromOrigin(p) {
-        return new Line({
-            x: 0,
-            y: 0
-        }, p);
-    };
     var Point = function Point() {
         "use strict";
         _class_call_check(this, Point);
@@ -19,5 +13,11 @@ var A;
         this.end = end;
     };
     A.Line = Line;
+    function fromOrigin(p) {
+        return new Line({
+            x: 0,
+            y: 0
+        }, p);
+    }
     A.fromOrigin = fromOrigin;
 })(A || (A = {}));

crates/swc/tests/tsc-references/ExportFunctionWithInaccessibleTypesInReturnTypeAnnotation.1.normal.js

@@ -2,12 +2,6 @@
 import { _ as _class_call_check } from "@swc/helpers/_/_class_call_check";
 var A;
 (function(A) {
-    var fromOrigin = function fromOrigin(p) {
-        return new Line({
-            x: 0,
-            y: 0
-        }, p);
-    };
     var Point = function Point() {
         "use strict";
         _class_call_check(this, Point);
@@ -19,5 +13,11 @@ var A;
         this.start = start;
         this.end = end;
     };
+    function fromOrigin(p) {
+        return new Line({
+            x: 0,
+            y: 0
+        }, p);
+    }
     A.fromOrigin = fromOrigin;
 })(A || (A = {}));

crates/swc/tests/tsc-references/FunctionAndModuleWithSameNameAndCommonRoot.1.normal.js

@@ -1,12 +1,12 @@
 //// [function.ts]
 var A;
 (function(A) {
-    var Point = function Point() {
+    function Point() {
         return {
             x: 0,
             y: 0
         };
-    };
+    }
     A.Point = Point;
 })(A || (A = {}));
 //// [module.ts]
@@ -29,12 +29,12 @@ var cl = A.Point.Origin; // not expected to be an error.
 //// [simple.ts]
 var B;
 (function(B) {
-    var Point = function Point() {
+    function Point() {
         return {
             x: 0,
             y: 0
         };
-    };
+    }
     B.Point = Point;
     (function(Point) {
         Point.Origin = {

crates/swc/tests/tsc-references/FunctionAndModuleWithSameNameAndCommonRoot.2.minified.js

@@ -16,13 +16,16 @@ var A, A1;
 A.Point, A.Point(), A.Point.Origin;
  // not expected to be an error.
 //// [simple.ts]
-var B, B1, Point;
-Point = function() {
-    return {
+var B;
+!function(B) {
+    function Point() {
+        return {
+            x: 0,
+            y: 0
+        };
+    }
+    B.Point = Point, (Point = B.Point || (B.Point = {})).Origin = {
         x: 0,
         y: 0
     };
-}, (B1 = B || (B = {})).Point = Point, (Point = B1.Point || (B1.Point = {})).Origin = {
-    x: 0,
-    y: 0
-}, B.Point, B.Point(), B.Point.Origin;
+}(B || (B = {})), B.Point, B.Point(), B.Point.Origin;

crates/swc/tests/tsc-references/FunctionAndModuleWithSameNameAndDifferentCommonRoot.1.normal.js

@@ -1,12 +1,12 @@
 //// [function.ts]
 var A;
 (function(A) {
-    var Point = function Point() {
+    function Point() {
         return {
             x: 0,
             y: 0
         };
-    };
+    }
     A.Point = Point;
 })(A || (A = {}));
 //// [module.ts]

crates/swc/tests/tsc-references/ModuleAndFunctionWithSameNameAndCommonRoot.1.normal.js

@@ -12,31 +12,31 @@ var A;
 //// [function.ts]
 var A;
 (function(A) {
-    var Point = function Point() {
+    function Point() {
         return {
             x: 0,
             y: 0
         };
-    };
+    }
     // duplicate identifier error
     A.Point = Point;
 })(A || (A = {}));
 //// [simple.ts]
 var B;
 (function(B) {
-    var Point = function Point() {
-        return {
-            x: 0,
-            y: 0
-        };
-    };
     var Point;
     (function(Point) {
         Point.Origin = {
             x: 0,
             y: 0
         };
     })(Point = B.Point || (B.Point = {}));
+    function Point() {
+        return {
+            x: 0,
+            y: 0
+        };
+    }
     // duplicate identifier error
     B.Point = Point;
 })(B || (B = {}));