feat(es/minifier): Inline into the arguments of new using seq inlin…

…er (#8127)

crates/swc_ecma_minifier/src/compress/optimize/sequences.rs

@@ -1855,13 +1855,33 @@ impl Optimizer<'_> {
             }
 
             Expr::New(NewExpr {
-                callee: b_callee, ..
+                callee: b_callee,
+                args: b_args,
+                ..
             }) => {
                 trace_op!("seq: Try callee of new");
                 if self.merge_sequential_expr(a, b_callee)? {
                     return Ok(true);
                 }
 
+                if !self.is_skippable_for_seq(Some(a), b_callee) {
+                    return Ok(false);
+                }
+
+                if let Some(b_args) = b_args {
+                    for arg in b_args {
+                        trace_op!("seq: Try arg of new exp");
+
+                        if self.merge_sequential_expr(a, &mut arg.expr)? {
+                            return Ok(true);
+                        }
+
+                        if !self.is_skippable_for_seq(Some(a), &arg.expr) {
+                            return Ok(false);
+                        }
+                    }
+                }
+
                 return Ok(false);
             }
 

crates/swc_ecma_minifier/tests/benches-full/d3.js

@@ -1294,7 +1294,7 @@
         return a <= 0 && (r = g = b = NaN), new Rgb(r, g, b, a);
     }
     function rgbConvert(o) {
-        return (o instanceof Color || (o = color(o)), o) ? (o = o.rgb(), new Rgb(o.r, o.g, o.b, o.opacity)) : new Rgb;
+        return (o instanceof Color || (o = color(o)), o) ? new Rgb((o = o.rgb()).r, o.g, o.b, o.opacity) : new Rgb;
     }
     function rgb(r, g, b, opacity) {
         return 1 == arguments.length ? rgbConvert(r) : new Rgb(r, g, b, null == opacity ? 1 : opacity);
@@ -1433,7 +1433,7 @@
         },
         rgb: function() {
             var y = (this.l + 16) / 116, x = isNaN(this.a) ? y : y + this.a / 500, z = isNaN(this.b) ? y : y - this.b / 200;
-            return x = 0.96422 * lab2xyz(x), y = 1 * lab2xyz(y), z = 0.82521 * lab2xyz(z), new Rgb(lrgb2rgb(3.1338561 * x - 1.6168667 * y - 0.4906146 * z), lrgb2rgb(-0.9787684 * x + 1.9161415 * y + 0.0334540 * z), lrgb2rgb(0.0719453 * x - 0.2289914 * y + 1.4052427 * z), this.opacity);
+            return new Rgb(lrgb2rgb(3.1338561 * (x = 0.96422 * lab2xyz(x)) - 1.6168667 * (y = 1 * lab2xyz(y)) - 0.4906146 * (z = 0.82521 * lab2xyz(z))), lrgb2rgb(-0.9787684 * x + 1.9161415 * y + 0.0334540 * z), lrgb2rgb(0.0719453 * x - 0.2289914 * y + 1.4052427 * z), this.opacity);
         }
     })), define1(Hcl, hcl, extend(Color, {
         brighter: function(k) {

crates/swc_ecma_minifier/tests/benches-full/terser.js

@@ -1523,10 +1523,10 @@
                 }
                 {
                     const AccessorClass = "get" === accessor_type ? AST_ObjectGetter : AST_ObjectSetter;
-                    return name = get_symbol_ast(name), new AccessorClass({
+                    return new AccessorClass({
                         start,
                         static: is_static,
-                        key: name,
+                        key: name = get_symbol_ast(name),
                         quote: name instanceof AST_SymbolMethod ? property_token.quote : void 0,
                         value: create_accessor(),
                         end: prev()
@@ -18003,7 +18003,7 @@
                     var entries = fs.readdirSync(dir);
                 } catch (ex) {}
                 if (entries) {
-                    var pattern = "^" + path.basename(glob).replace(/[.+^$[\]\\(){}]/g, "\\$&").replace(/\*/g, "[^/\\\\]*").replace(/\?/g, "[^/\\\\]") + "$", mod = "win32" === process.platform ? "i" : "", rx = new RegExp(pattern, mod), results = entries.filter(function(name) {
+                    var rx = RegExp("^" + path.basename(glob).replace(/[.+^$[\]\\(){}]/g, "\\$&").replace(/\*/g, "[^/\\\\]*").replace(/\?/g, "[^/\\\\]") + "$", "win32" === process.platform ? "i" : ""), results = entries.filter(function(name) {
                         return rx.test(name);
                     }).map(function(name) {
                         return path.join(dir, name);

crates/swc_ecma_minifier/tests/benches-full/three.js

@@ -7232,7 +7232,7 @@
         },
         clone: function(data) {
             void 0 === data.arrayBuffers && (data.arrayBuffers = {}), void 0 === this.array.buffer._uuid && (this.array.buffer._uuid = MathUtils.generateUUID()), void 0 === data.arrayBuffers[this.array.buffer._uuid] && (data.arrayBuffers[this.array.buffer._uuid] = this.array.slice(0).buffer);
-            var array = new this.array.constructor(data.arrayBuffers[this.array.buffer._uuid]), ib = new InterleavedBuffer(array, this.stride);
+            var ib = new InterleavedBuffer(new this.array.constructor(data.arrayBuffers[this.array.buffer._uuid]), this.stride);
             return ib.setUsage(this.usage), ib;
         },
         onUpload: function(callback) {
@@ -7339,7 +7339,7 @@
     function Sprite(material) {
         if (Object3D.call(this), this.type = 'Sprite', void 0 === _geometry) {
             _geometry = new BufferGeometry();
-            var float32Array = new Float32Array([
+            var interleavedBuffer = new InterleavedBuffer(new Float32Array([
                 -0.5,
                 -0.5,
                 0,
@@ -7360,7 +7360,7 @@
                 0,
                 0,
                 1
-            ]), interleavedBuffer = new InterleavedBuffer(float32Array, 5);
+            ]), 5);
             _geometry.setIndex([
                 0,
                 1,
@@ -11148,9 +11148,9 @@
             return this.curves.push(curve), this.currentPoint.set(aX, aY), this;
         },
         splineThru: function(pts) {
-            var npts = [
+            var curve = new SplineCurve([
                 this.currentPoint.clone()
-            ].concat(pts), curve = new SplineCurve(npts);
+            ].concat(pts));
             return this.curves.push(curve), this.currentPoint.copy(pts[pts.length - 1]), this;
         },
         arc: function(aX, aY, aRadius, aStartAngle, aEndAngle, aClockwise) {
@@ -11550,7 +11550,7 @@
                     if (void 0 !== arrayBufferMap[uuid]) return arrayBufferMap[uuid];
                     var arrayBuffer = json.arrayBuffers[uuid], ab = new Uint32Array(arrayBuffer).buffer;
                     return arrayBufferMap[uuid] = ab, ab;
-                }(json, interleavedBuffer.buffer), array = getTypedArray(interleavedBuffer.type, buffer), ib = new InterleavedBuffer(array, interleavedBuffer.stride);
+                }(json, interleavedBuffer.buffer), ib = new InterleavedBuffer(getTypedArray(interleavedBuffer.type, buffer), interleavedBuffer.stride);
                 return ib.uuid = interleavedBuffer.uuid, interleavedBufferMap[uuid] = ib, ib;
             }
             var geometry = json.isInstancedBufferGeometry ? new InstancedBufferGeometry() : new BufferGeometry(), index = json.data.index;
@@ -11561,10 +11561,8 @@
             var attributes = json.data.attributes;
             for(var key in attributes){
                 var attribute = attributes[key], bufferAttribute = void 0;
-                if (attribute.isInterleavedBufferAttribute) {
-                    var interleavedBuffer = getInterleavedBuffer(json.data, attribute.data);
-                    bufferAttribute = new InterleavedBufferAttribute(interleavedBuffer, attribute.itemSize, attribute.offset, attribute.normalized);
-                } else {
+                if (attribute.isInterleavedBufferAttribute) bufferAttribute = new InterleavedBufferAttribute(getInterleavedBuffer(json.data, attribute.data), attribute.itemSize, attribute.offset, attribute.normalized);
+                else {
                     var _typedArray = getTypedArray(attribute.type, attribute.array);
                     bufferAttribute = new (attribute.isInstancedBufferAttribute ? InstancedBufferAttribute : BufferAttribute)(_typedArray, attribute.itemSize, attribute.normalized);
                 }
@@ -11574,14 +11572,7 @@
             if (morphAttributes) for(var _key in morphAttributes){
                 for(var attributeArray = morphAttributes[_key], array = [], i = 0, il = attributeArray.length; i < il; i++){
                     var _attribute = attributeArray[i], _bufferAttribute = void 0;
-                    if (_attribute.isInterleavedBufferAttribute) {
-                        var _interleavedBuffer = getInterleavedBuffer(json.data, _attribute.data);
-                        _bufferAttribute = new InterleavedBufferAttribute(_interleavedBuffer, _attribute.itemSize, _attribute.offset, _attribute.normalized);
-                    } else {
-                        var _typedArray2 = getTypedArray(_attribute.type, _attribute.array);
-                        _bufferAttribute = new BufferAttribute(_typedArray2, _attribute.itemSize, _attribute.normalized);
-                    }
-                    void 0 !== _attribute.name && (_bufferAttribute.name = _attribute.name), array.push(_bufferAttribute);
+                    _bufferAttribute = _attribute.isInterleavedBufferAttribute ? new InterleavedBufferAttribute(getInterleavedBuffer(json.data, _attribute.data), _attribute.itemSize, _attribute.offset, _attribute.normalized) : new BufferAttribute(getTypedArray(_attribute.type, _attribute.array), _attribute.itemSize, _attribute.normalized), void 0 !== _attribute.name && (_bufferAttribute.name = _attribute.name), array.push(_bufferAttribute);
                 }
                 geometry.morphAttributes[_key] = array;
             }
@@ -11792,8 +11783,7 @@
                 } : null;
             }
             if (void 0 !== json && json.length > 0) {
-                var manager = new LoadingManager(onLoad);
-                (loader = new ImageLoader(manager)).setCrossOrigin(this.crossOrigin);
+                (loader = new ImageLoader(new LoadingManager(onLoad))).setCrossOrigin(this.crossOrigin);
                 for(var i = 0, il = json.length; i < il; i++){
                     var image = json[i], url = image.url;
                     if (Array.isArray(url)) {
@@ -11869,10 +11859,10 @@
                     object = new LightProbe().fromJSON(data);
                     break;
                 case 'SkinnedMesh':
-                    geometry = getGeometry(data.geometry), material = getMaterial(data.material), object = new SkinnedMesh(geometry, material), void 0 !== data.bindMode && (object.bindMode = data.bindMode), void 0 !== data.bindMatrix && object.bindMatrix.fromArray(data.bindMatrix), void 0 !== data.skeleton && (object.skeleton = data.skeleton);
+                    object = new SkinnedMesh(geometry = getGeometry(data.geometry), material = getMaterial(data.material)), void 0 !== data.bindMode && (object.bindMode = data.bindMode), void 0 !== data.bindMatrix && object.bindMatrix.fromArray(data.bindMatrix), void 0 !== data.skeleton && (object.skeleton = data.skeleton);
                     break;
                 case 'Mesh':
-                    geometry = getGeometry(data.geometry), material = getMaterial(data.material), object = new Mesh(geometry, material);
+                    object = new Mesh(geometry = getGeometry(data.geometry), material = getMaterial(data.material));
                     break;
                 case 'InstancedMesh':
                     geometry = getGeometry(data.geometry), material = getMaterial(data.material);
@@ -13972,8 +13962,7 @@
         new Vector3(-PHI, INV_PHI, 0)
     ], PMREMGenerator = function() {
         function PMREMGenerator(renderer) {
-            var weights, poleAxis;
-            this._renderer = renderer, this._pingPongRenderTarget = null, this._blurMaterial = (weights = new Float32Array(20), poleAxis = new Vector3(0, 1, 0), new RawShaderMaterial({
+            this._renderer = renderer, this._pingPongRenderTarget = null, this._blurMaterial = new RawShaderMaterial({
                 name: 'SphericalGaussianBlur',
                 defines: {
                     n: 20
@@ -13986,7 +13975,7 @@
                         value: 1
                     },
                     weights: {
-                        value: weights
+                        value: new Float32Array(20)
                     },
                     latitudinal: {
                         value: !1
@@ -13998,7 +13987,7 @@
                         value: 0
                     },
                     poleAxis: {
-                        value: poleAxis
+                        value: new Vector3(0, 1, 0)
                     },
                     inputEncoding: {
                         value: ENCODINGS[3000]
@@ -14012,7 +14001,7 @@
                 blending: 0,
                 depthTest: !1,
                 depthWrite: !1
-            })), this._equirectShader = null, this._cubemapShader = null, this._compileMaterial(this._blurMaterial);
+            }), this._equirectShader = null, this._cubemapShader = null, this._compileMaterial(this._blurMaterial);
         }
         var _proto = PMREMGenerator.prototype;
         return _proto.fromScene = function(scene, sigma, near, far) {
@@ -14119,15 +14108,14 @@
         target.viewport.set(x, y, width, height), target.scissor.set(x, y, width, height);
     }
     function _getEquirectShader() {
-        var texelSize = new Vector2(1, 1);
         return new RawShaderMaterial({
             name: 'EquirectangularToCubeUV',
             uniforms: {
                 envMap: {
                     value: null
                 },
                 texelSize: {
-                    value: texelSize
+                    value: new Vector2(1, 1)
                 },
                 inputEncoding: {
                     value: ENCODINGS[3000]

crates/swc_ecma_minifier/tests/benches-full/victory.js

@@ -944,7 +944,7 @@
                 return a <= 0 && (r = g = b = NaN), new Rgb(r, g, b, a);
             }
             function rgbConvert(o) {
-                return (o instanceof Color || (o = color(o)), o) ? (o = o.rgb(), new Rgb(o.r, o.g, o.b, o.opacity)) : new Rgb;
+                return (o instanceof Color || (o = color(o)), o) ? new Rgb((o = o.rgb()).r, o.g, o.b, o.opacity) : new Rgb;
             }
             function rgb(r, g, b, opacity) {
                 return 1 == arguments.length ? rgbConvert(r) : new Rgb(r, g, b, null == opacity ? 1 : opacity);
@@ -8436,10 +8436,7 @@
                         return createChainableTypeChecker(function(props, propName, componentName, location, propFullName) {
                             if ('function' != typeof typeChecker) return new PropTypeError('Property `' + propFullName + '` of component `' + componentName + '` has invalid PropType notation inside arrayOf.');
                             var propValue = props[propName];
-                            if (!Array.isArray(propValue)) {
-                                var propType = getPropType(propValue);
-                                return new PropTypeError('Invalid ' + location + ' `' + propFullName + '` of type ' + ('`' + propType) + '` supplied to `' + componentName + '`, expected an array.');
-                            }
+                            if (!Array.isArray(propValue)) return new PropTypeError('Invalid ' + location + ' `' + propFullName + '` of type ' + ('`' + getPropType(propValue)) + '` supplied to `' + componentName + '`, expected an array.');
                             for(var i = 0; i < propValue.length; i++){
                                 var error = typeChecker(propValue, i, componentName, location, propFullName + '[' + i + ']', ReactPropTypesSecret);
                                 if (error instanceof Error) return error;
@@ -8449,25 +8446,17 @@
                     },
                     element: createChainableTypeChecker(function(props, propName, componentName, location, propFullName) {
                         var propValue = props[propName];
-                        if (!isValidElement(propValue)) {
-                            var propType = getPropType(propValue);
-                            return new PropTypeError('Invalid ' + location + ' `' + propFullName + '` of type ' + ('`' + propType) + '` supplied to `' + componentName + '`, expected a single ReactElement.');
-                        }
-                        return null;
+                        return isValidElement(propValue) ? null : new PropTypeError('Invalid ' + location + ' `' + propFullName + '` of type ' + ('`' + getPropType(propValue)) + '` supplied to `' + componentName + '`, expected a single ReactElement.');
                     }),
                     elementType: createChainableTypeChecker(function(props, propName, componentName, location, propFullName) {
                         var propValue = props[propName];
-                        if (!ReactIs.isValidElementType(propValue)) {
-                            var propType = getPropType(propValue);
-                            return new PropTypeError('Invalid ' + location + ' `' + propFullName + '` of type ' + ('`' + propType) + '` supplied to `' + componentName + '`, expected a single ReactElement type.');
-                        }
-                        return null;
+                        return ReactIs.isValidElementType(propValue) ? null : new PropTypeError('Invalid ' + location + ' `' + propFullName + '` of type ' + ('`' + getPropType(propValue)) + '` supplied to `' + componentName + '`, expected a single ReactElement type.');
                     }),
                     instanceOf: function(expectedClass) {
                         return createChainableTypeChecker(function(props, propName, componentName, location, propFullName) {
                             if (!(props[propName] instanceof expectedClass)) {
-                                var propValue, expectedClassName = expectedClass.name || ANONYMOUS, actualClassName = (propValue = props[propName]).constructor && propValue.constructor.name ? propValue.constructor.name : ANONYMOUS;
-                                return new PropTypeError('Invalid ' + location + ' `' + propFullName + '` of type ' + ('`' + actualClassName) + '` supplied to `' + componentName + "`, expected instance of `" + expectedClassName + '`.');
+                                var propValue, expectedClassName = expectedClass.name || ANONYMOUS;
+                                return new PropTypeError('Invalid ' + location + ' `' + propFullName + '` of type ' + ('`' + ((propValue = props[propName]).constructor && propValue.constructor.name ? propValue.constructor.name : ANONYMOUS)) + '` supplied to `' + componentName + "`, expected instance of `" + expectedClassName + '`.');
                             }
                             return null;
                         });
@@ -8600,11 +8589,7 @@
                 function createPrimitiveTypeChecker(expectedType) {
                     return createChainableTypeChecker(function(props, propName, componentName, location, propFullName, secret) {
                         var propValue = props[propName];
-                        if (getPropType(propValue) !== expectedType) {
-                            var preciseType = getPreciseType(propValue);
-                            return new PropTypeError('Invalid ' + location + ' `' + propFullName + '` of type ' + ('`' + preciseType) + '` supplied to `' + componentName + "`, expected `" + expectedType + '`.');
-                        }
-                        return null;
+                        return getPropType(propValue) !== expectedType ? new PropTypeError('Invalid ' + location + ' `' + propFullName + '` of type ' + ('`' + getPreciseType(propValue)) + '` supplied to `' + componentName + "`, expected `" + expectedType + '`.') : null;
                     });
                 }
                 function getPropType(propValue) {

crates/swc_ecma_minifier/tests/fixture/issues/2257/full/output.js

@@ -4926,7 +4926,7 @@
                             length = byteLength / BYTES;
                         } else if (isTypedArray(data)) return fromList(TypedArrayConstructor, data);
                         else return typedArrayFrom.call(TypedArrayConstructor, data);
-                    } else byteLength = (length = toIndex(data)) * BYTES, buffer = new ArrayBuffer1(byteLength);
+                    } else buffer = new ArrayBuffer1(byteLength = (length = toIndex(data)) * BYTES);
                     for(setInternalState(that, {
                         buffer: buffer,
                         byteOffset: byteOffset,