chore: remove unused, always empty fields from TsPropertySignature

TsPropertySignature can not have params, type params, or an initializer.
swc-project · May 14, 2024 · 2d4f3e9 · 2d4f3e9
1 parent 53e1ae2
commit 2d4f3e9
Show file tree

Hide file tree

Showing 7 changed files with 0 additions and 26 deletions.
diff --git a/crates/swc_ecma_ast/src/typescript.rs b/crates/swc_ecma_ast/src/typescript.rs
@@ -185,13 +185,8 @@ pub struct TsPropertySignature {
     pub key: Box<Expr>,
     pub computed: bool,
     pub optional: bool,
-    #[cfg_attr(feature = "serde-impl", serde(default))]
-    pub init: Option<Box<Expr>>,
-    pub params: Vec<TsFnParam>,
     #[cfg_attr(feature = "serde-impl", serde(default, rename = "typeAnnotation"))]
     pub type_ann: Option<Box<TsTypeAnn>>,
-    #[cfg_attr(feature = "serde-impl", serde(default))]
-    pub type_params: Option<Box<TsTypeParamDecl>>,
 }
 
 #[ast_node("TsGetterSignature")]

diff --git a/crates/swc_ecma_codegen/src/typescript.rs b/crates/swc_ecma_codegen/src/typescript.rs
@@ -741,8 +741,6 @@ where
             punct!("?");
         }
 
-        emit!(n.type_params);
-
         // punct!("(");
         // self.emit_list(n.span, Some(&n.params), ListFormat::Parameters)?;
         // punct!(")");
@@ -752,13 +750,6 @@ where
             formatting_space!();
             emit!(type_ann);
         }
-
-        if let Some(init) = &n.init {
-            formatting_space!();
-            punct!("=");
-            formatting_space!();
-            emit!(init);
-        }
     }
 
     #[emitter]

diff --git a/crates/swc_ecma_parser/src/parser/typescript.rs b/crates/swc_ecma_parser/src/parser/typescript.rs
@@ -1449,9 +1449,6 @@ impl<I: Tokens> Parser<I> {
                 readonly,
                 key,
                 optional,
-                init: None,
-                type_params: None,
-                params: vec![],
                 type_ann,
             }))
         }

diff --git a/crates/swc_ecma_transforms_base/src/resolver/mod.rs b/crates/swc_ecma_transforms_base/src/resolver/mod.rs
@@ -1401,9 +1401,6 @@ impl<'a> VisitMut for Resolver<'a> {
         self.with_child(ScopeKind::Fn, |child| {
             child.in_type = true;
 
-            n.type_params.visit_mut_with(child);
-            n.init.visit_mut_with(child);
-            n.params.visit_mut_with(child);
             n.type_ann.visit_mut_with(child);
         });
     }

diff --git a/crates/swc_ecma_visit/src/lib.rs b/crates/swc_ecma_visit/src/lib.rs
@@ -1531,10 +1531,7 @@ define!({
         pub key: Box<Expr>,
         pub computed: bool,
         pub optional: bool,
-        pub init: Option<Box<Expr>>,
-        pub params: Vec<TsFnParam>,
         pub type_ann: Option<Box<TsTypeAnn>>,
-        pub type_params: Option<Box<TsTypeParamDecl>>,
     }
 
     pub struct TsGetterSignature {

diff --git a/crates/swc_estree_ast/src/typescript.rs b/crates/swc_estree_ast/src/typescript.rs
@@ -289,8 +289,6 @@ pub struct TSPropertySignature {
     #[serde(default)]
     pub type_annotation: Option<Box<TSTypeAnnotation>>,
     #[serde(default)]
-    pub initializer: Option<Box<Expression>>,
-    #[serde(default)]
     pub computed: Option<bool>,
     #[serde(default)]
     pub optional: Option<bool>,

diff --git a/crates/swc_estree_compat/src/babelify/typescript.rs b/crates/swc_estree_compat/src/babelify/typescript.rs
@@ -261,7 +261,6 @@ impl Babelify for TsPropertySignature {
             type_annotation: self
                 .type_ann
                 .map(|ann| Box::alloc().init(ann.babelify(ctx))),
-            initializer: self.init.map(|i| Box::alloc().init(i.babelify(ctx).into())),
             computed: Some(self.computed),
             optional: Some(self.optional),
             readonly: Some(self.readonly),