refactor(estree/compat): Do not use nightly features (#9772)

**Related issue:** - Closes #9770
swc-project · Dec 2, 2024 · 0f12bbd · 0f12bbd
1 parent 0adad25
commit 0f12bbd
Show file tree

Hide file tree

Showing 4 changed files with 20 additions and 11 deletions.
diff --git a/.changeset/curvy-icons-drum.md b/.changeset/curvy-icons-drum.md
@@ -0,0 +1,6 @@
+---
+swc_estree_compat: patch
+swc_core: patch
+---
+
+refactor(estree/compat): Do not use nightly features
diff --git a/crates/swc_estree_compat/src/lib.rs b/crates/swc_estree_compat/src/lib.rs
@@ -1,7 +1,10 @@
 #![deny(clippy::all)]
 #![allow(clippy::large_enum_variant)]
 #![allow(clippy::upper_case_acronyms)]
-#![feature(never_type)]
+
+use std::convert::Infallible;
 
 pub mod babelify;
 pub mod swcify;
+
+pub type Never = Infallible;
diff --git a/crates/swc_estree_compat/src/swcify/expr.rs b/crates/swc_estree_compat/src/swcify/expr.rs
@@ -27,7 +27,7 @@ use swc_estree_ast::{
 };
 
 use super::Context;
-use crate::swcify::Swcify;
+use crate::{swcify::Swcify, Never};
 
 impl Swcify for Expression {
     type Output = Box<Expr>;
@@ -819,7 +819,7 @@ impl Swcify for OptionalCallExpression {
 }
 
 impl Swcify for TypeCastExpression {
-    type Output = !;
+    type Output = Never;
 
     fn swcify(self, _: &Context) -> Self::Output {
         unimplemented!("flow type cast")
@@ -1083,47 +1083,47 @@ impl Swcify for swc_estree_ast::JSXClosingFragment {
 }
 
 impl Swcify for BindExpression {
-    type Output = !;
+    type Output = Never;
 
     fn swcify(self, _: &Context) -> Self::Output {
         panic!("swc does not support bind expressions")
     }
 }
 
 impl Swcify for DoExpression {
-    type Output = !;
+    type Output = Never;
 
     fn swcify(self, _: &Context) -> Self::Output {
         panic!("swc does not support do expressions")
     }
 }
 
 impl Swcify for PipelinePrimaryTopicReference {
-    type Output = !;
+    type Output = Never;
 
     fn swcify(self, _: &Context) -> Self::Output {
         panic!("swc does not support `PipelinePrimaryTopicReference`")
     }
 }
 
 impl Swcify for RecordExpression {
-    type Output = !;
+    type Output = Never;
 
     fn swcify(self, _: &Context) -> Self::Output {
         panic!("swc does not support record expressions")
     }
 }
 
 impl Swcify for TupleExpression {
-    type Output = !;
+    type Output = Never;
 
     fn swcify(self, _: &Context) -> Self::Output {
         panic!("swc does not support tuple expressions")
     }
 }
 
 impl Swcify for ModuleExpression {
-    type Output = !;
+    type Output = Never;
 
     fn swcify(self, _: &Context) -> Self::Output {
         panic!("swc does not support module expressions")

diff --git a/crates/swc_estree_compat/src/swcify/typescript.rs b/crates/swc_estree_compat/src/swcify/typescript.rs
@@ -9,7 +9,7 @@ use swc_estree_ast::{
 };
 
 use super::Context;
-use crate::swcify::Swcify;
+use crate::{swcify::Swcify, Never};
 
 impl Swcify for TSTypeParameterInstantiation {
     type Output = TsTypeParamInstantiation;
@@ -23,7 +23,7 @@ impl Swcify for TSTypeParameterInstantiation {
 }
 
 impl Swcify for FlowType {
-    type Output = !;
+    type Output = Never;
 
     fn swcify(self, _: &Context) -> Self::Output {
         unreachable!("swc does not support flow types")