Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop using rollup-plugin-mjs-entry #32

Merged
merged 1 commit into from
Oct 27, 2023
Merged

Conversation

swansontec
Copy link
Owner

@swansontec swansontec commented Oct 25, 2023

This plugin seems to be causing problems. Instead, just bundle the package twice as CJS and MJS.

We keep the file extensions as ".js", since that's the most compatible.


Copy link

@samholmes samholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I just had some questions about this one though as a sidebar.

Copy link

@samholmes samholmes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. I just had some questions about this one though as a sidebar.

package.json Outdated Show resolved Hide resolved
package.json Outdated Show resolved Hide resolved
This plugin seems to be causing problems. Instead, just bundle the package twice as CJS and MJS.

We keep the file extensions as ".js", since that's the most compatible.
@swansontec swansontec force-pushed the william/fix-packaging branch from 0084171 to 401498a Compare October 27, 2023 18:07
@swansontec swansontec merged commit 42ad32b into master Oct 27, 2023
@swansontec swansontec deleted the william/fix-packaging branch October 27, 2023 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants