ENH: use studentized range over statsmodels for pvalue #1
Conversation
|
Great. Do you know that's all of them? Do tests pass? |
pingouin/pairwise.py
Outdated
| @@ -664,7 +664,7 @@ def pairwise_tukey(data=None, dv=None, between=None, effsize='hedges'): | |||
| # Critical values and p-values | |||
| # from statsmodels.stats.libqsturng import qsturng | |||
There was a problem hiding this comment.
Even if it's commented out, let's change it.
These would be all the places Dominic changed in raphaelvallatgh-156, but it's possible new uses have been added since then. Have you searched the repo for qsturng and psturng?
There was a problem hiding this comment.
I changed what dominic originally changed
There was a problem hiding this comment.
OK, please do a search to double-check that nothing new has been added since then, and please change this commented-out stuff, too.
Then, if their tests pass, feel free to open up a PR to the main repo.
Thanks!
There was a problem hiding this comment.
and yes, I did check for all uses. tests continue to pass
swallan
force-pushed
the
use_scipy_studentized_range_over_statsmodels
branch
from
e7b1e21
to
6443bd3
Compare
|
All tests pass, I don't see any other appearances of
|
No description provided.