Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to set 'swaggerignore' on embedded fields #779

Merged
merged 1 commit into from
Aug 27, 2020
Merged

Add ability to set 'swaggerignore' on embedded fields #779

merged 1 commit into from
Aug 27, 2020

Conversation

ffenix113
Copy link
Contributor

Describe the PR
This PR adds ability to set swaggerignore:"true" on embedded fields.

Relation issue
#632

Additional context
Currently swaggerignore supports only ignoring named fields, while in some cases it is also useful to be able to ignore embedded fields.

@codecov
Copy link

codecov bot commented Aug 20, 2020

Codecov Report

Merging #779 into master will increase coverage by 0.04%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #779      +/-   ##
==========================================
+ Coverage   82.16%   82.20%   +0.04%     
==========================================
  Files           8        8              
  Lines        1744     1748       +4     
==========================================
+ Hits         1433     1437       +4     
  Misses        193      193              
  Partials      118      118              
Impacted Files Coverage Δ
parser.go 77.24% <100.00%> (+0.10%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1889a3a...305327c. Read the comment docs.

@ffenix113
Copy link
Contributor Author

@easonlin404 @sdghchj @pei0804 Could you please review guys?

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good for me. @sdghchj Could you help review as well?

@sdghchj
Copy link
Member

sdghchj commented Aug 26, 2020

It's OK

@easonlin404 easonlin404 merged commit 6a59a20 into swaggo:master Aug 27, 2020
@easonlin404
Copy link
Member

@ffenix113 Thanks for your contributions. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants