Parse depth #766
Merged
Parse depth #766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
August 4, 2020 14:20
Codecov Report
@@ Coverage Diff @@
## master #766 +/- ##
==========================================
- Coverage 82.21% 82.10% -0.11%
==========================================
Files 8 8
Lines 1737 1738 +1
==========================================
- Hits 1428 1427 -1
- Misses 192 193 +1
- Partials 117 118 +1
Continue to review full report at Codecov.
|
sdghchj
reviewed
Aug 5, 2020
sdghchj
approved these changes
Aug 5, 2020
|
@sdghchj I would consider drop code coverage checks if needs so that you can merge PR. |
easonlin404
reviewed
Aug 6, 2020
| Usage: "Generate timestamp at the top of docs.go, true by default", | ||
| }, | ||
| &cli.IntFlag{ | ||
| Name: parseDepthFlag, |
There was a problem hiding this comment.
@necryin could you help pull a new PR to update https://github.com/swaggo/swag#swag-cli as well ?
That would be nice |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
add parseDepth flag for speed up generate
on my laptop right parseDepth flag give ~x3 speed up (1m -> 23sec)