Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stable renaming to fix issue #745; uncapitalize two members of parser #746

Merged
merged 5 commits into from
Jul 12, 2020
Merged

stable renaming to fix issue #745; uncapitalize two members of parser #746

merged 5 commits into from
Jul 12, 2020

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Jul 7, 2020

Describe the PR
rename all the name-conflicted models for a stable parsing result.

Relation issue
#745

@sdghchj sdghchj closed this Jul 7, 2020
@sdghchj sdghchj reopened this Jul 12, 2020
@codecov
Copy link

codecov bot commented Jul 12, 2020 •
edited
Loading

Codecov Report

Merging #746 into master will increase coverage by 1.33%.
The diff coverage is 93.75%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #746      +/-   ##
==========================================
+ Coverage   80.76%   82.09%   +1.33%     
==========================================
  Files           8        8              
  Lines        1710     1737      +27     
==========================================
+ Hits         1381     1426      +45     
+ Misses        211      193      -18     
  Partials      118      118
Impacted Files Coverage Δ
parser.go 76.94% <93.75%> (+1.10%) ⬆️
packages.go 73.33% <0.00%> (+12.50%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update cbfd47b...99b4b09. Read the comment docs.

@sdghchj sdghchj requested a review from easonlin404 July 12, 2020 14:47
@sdghchj
Copy link
Member Author

sdghchj commented Jul 12, 2020

@easonlin404 @krishna-birla

easonlin404
easonlin404 approved these changes Jul 12, 2020
View reviewed changes
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

krishna-birla
krishna-birla approved these changes Jul 12, 2020
View reviewed changes
Copy link

@krishna-birla krishna-birla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Unit tests describe the expected behaviour well.

@sdghchj sdghchj merged commit ec7a5ee into master Jul 12, 2020
@sdghchj sdghchj deleted the issue745 branch July 12, 2020 23:10
@sdghchj sdghchj changed the title stable renaming to fix issue #745; uncapitalize tow members of parser stable renaming to fix issue #745; uncapitalize two members of parser Jul 20, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krishna-birla krishna-birla krishna-birla approved these changes

@easonlin404 easonlin404 easonlin404 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sdghchj @easonlin404 @krishna-birla