Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor step1: build spec.Schema; parse object in request #728

Merged
merged 5 commits into from
Jun 8, 2020

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Jun 6, 2020

Describe the PR
refactor step 1

@codecov-commenter
Copy link

codecov-commenter commented Jun 7, 2020

Codecov Report

Merging #728 into master will decrease coverage by 0.30%.
The diff coverage is 81.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #728      +/-   ##
==========================================
- Coverage   84.88%   84.58%   -0.31%     
==========================================
  Files           7        7              
  Lines        1872     1790      -82     
==========================================
- Hits         1589     1514      -75     
+ Misses        177      171       -6     
+ Partials      106      105       -1     
Impacted Files Coverage Δ
gen/gen.go 95.41% <71.42%> (-1.46%) ⬇️
operation.go 87.88% <78.57%> (+0.08%) ⬆️
parser.go 79.76% <85.71%> (-0.66%) ⬇️
schema.go 96.82% <100.00%> (+0.21%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df209af...4042880. Read the comment docs.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 67cb097 into master Jun 8, 2020
@easonlin404 easonlin404 deleted the refactored2 branch June 8, 2020 09:46
@tylfin
Copy link

tylfin commented Jun 10, 2020

Hmm, I think this broke something, I'm getting:

     {
     "name": "DESCRIPTION",
     "in": "body",
     "schema": {
-        "type": "string"
+        "type": "primitive"
     }

For this param:

// @Param distribution query string false "Name of the distribution to use."

@sdghchj
Copy link
Member Author

sdghchj commented Jun 10, 2020

@tylfin Got it, fix next PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants