Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix issue with urfave/cli #557

Merged
merged 16 commits into from
Nov 12, 2019
Merged

fix issue with urfave/cli #557

merged 16 commits into from
Nov 12, 2019

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Nov 11, 2019

Describe the PR
Fix urfave/cli dependecy

Relation issue
#556

Additional context
None.

@codecov-io
Copy link

codecov-io commented Nov 11, 2019

Codecov Report

Merging #557 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #557   +/-   ##
=======================================
  Coverage   87.24%   87.24%           
=======================================
  Files           7        7           
  Lines        1560     1560           
=======================================
  Hits         1361     1361           
  Misses        117      117           
  Partials       82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb06668...70354cc. Read the comment docs.

easonlin404
easonlin404 previously approved these changes Nov 12, 2019
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 changed the title Fix issue with urfave/cli fix issue with urfave/cli Nov 12, 2019
Makefile Show resolved Hide resolved
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 merged commit 75ecf95 into master Nov 12, 2019
@easonlin404 easonlin404 deleted the issue-556 branch November 12, 2019 10:25
@easonlin404 easonlin404 mentioned this pull request Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants