Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: use github action #528

Merged
merged 18 commits into from
Sep 25, 2019
Merged

chore: use github action #528

merged 18 commits into from
Sep 25, 2019

Conversation

pei0804
Copy link
Member

@pei0804 pei0804 commented Sep 22, 2019

Describe the PR
Benefits of using GitHubAction

  • Jobs running in 20 of parallel.
  • GitHubAPI will be easier to use.
  • Matrix tests are easy to write.
  • The job ends earlier than Travis.

@pei0804 pei0804 changed the title use github action [WIP]use github action Sep 22, 2019
@codecov-io
Copy link

codecov-io commented Sep 22, 2019

Codecov Report

Merging #528 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@          Coverage Diff           @@
##           master    #528   +/-   ##
======================================
  Coverage    86.9%   86.9%           
======================================
  Files           7       7           
  Lines        1550    1550           
======================================
  Hits         1347    1347           
  Misses        119     119           
  Partials       84      84

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update efcfb3d...646761a. Read the comment docs.

@pei0804
Copy link
Member Author

pei0804 commented Sep 22, 2019

I don't have the right of codecov, so I would like you to set it up in another PR.
If you set up token, I can do it.

        - name: Upload Coverage report to CodeCov
          uses: codecov/[email protected]
          with:
            token: ${{secrets.CODECOV_TOKEN}}
            file: ./profile.out

https://github.com/marketplace/actions/codecov

@pei0804
Copy link
Member Author

pei0804 commented Sep 22, 2019

@easonlin404
review please.

@pei0804 pei0804 changed the title [WIP]use github action use github action Sep 22, 2019
Makefile Show resolved Hide resolved
.github/workflows/ci.yaml Outdated Show resolved Hide resolved
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left comments.

@pei0804
Copy link
Member Author

pei0804 commented Sep 23, 2019

@easonlin404
commented

@appleboy
Copy link

@pei0804 Please rename the ci.yaml to ci.yml. GitHub can't load the extension with .yaml

.github/workflows/ci.yaml Outdated Show resolved Hide resolved
@pei0804
Copy link
Member Author

pei0804 commented Sep 24, 2019

@pei0804 Please rename the ci.yaml to ci.yml. GitHub can't load the extension with .yaml
OK!

@easonlin404
Copy link
Member

I don't have the right of codecov, so I would like you to set it up in another PR.
If you set up token, I can do it.

        - name: Upload Coverage report to CodeCov
          uses: codecov/[email protected]
          with:
            token: ${{secrets.CODECOV_TOKEN}}
            file: ./profile.out

https://github.com/marketplace/actions/codecov

Seems like don't need to setup if it's public repo, right?

@easonlin404 easonlin404 changed the title use github action chore: use github action Sep 24, 2019
@pei0804
Copy link
Member Author

pei0804 commented Sep 25, 2019

@easonlin404

#528 (comment)
token: ${{secrets.CODECOV_TOKEN}}
I want a token.
https://github.com/marketplace/actions/codecov#usage

I will check it a bit more.

@pei0804 pei0804 merged commit e0c8bbb into master Sep 25, 2019
@pei0804 pei0804 deleted the use-github-action branch September 25, 2019 01:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants