Fix nested struct parsing #514
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sts, it can not be parsed.
Codecov Report
@@ Coverage Diff @@
## master #514 +/- ##
==========================================
- Coverage 87.05% 86.78% -0.28%
==========================================
Files 7 7
Lines 1522 1536 +14
==========================================
+ Hits 1325 1333 +8
- Misses 115 119 +4
- Partials 82 84 +2
Continue to review full report at Codecov.
|
|
Can you please add test case for this scenario ? |
|
Great job ! Thanks for your contribution ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the PR
When I use swag, I found two problems;
Nested structs inside can not be parsed correctly.
When the response struct and the API function exist in the same file, the struct can not be parsed.
Relation issue
#504
Additional context
Add any other context about the problem here.