Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete deps for example. #492

Merged
merged 1 commit into from
Aug 9, 2019
Merged

delete deps for example. #492

merged 1 commit into from
Aug 9, 2019

Conversation

pei0804
Copy link
Member

@pei0804 pei0804 commented Aug 9, 2019

Describe the PR
#491 (comment)

go mod can't multi go.mod.
#491 (comment)

I decided to delete it once.
Please let me know if there are other ways.

@codecov-io
Copy link

codecov-io commented Aug 9, 2019

Codecov Report

Merging #492 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #492   +/-   ##
=======================================
  Coverage   87.05%   87.05%           
=======================================
  Files           7        7           
  Lines        1522     1522           
=======================================
  Hits         1325     1325           
  Misses        115      115           
  Partials       82       82

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9710e4b...7c7bb14. Read the comment docs.

@pei0804 pei0804 requested a review from a team August 9, 2019 02:40
Copy link
Contributor

@ubogdan ubogdan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ubogdan ubogdan merged commit 16ebb32 into master Aug 9, 2019
@ubogdan ubogdan deleted the update-go-mod branch August 9, 2019 08:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants