-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: error resolving host and basepath #475
Conversation
Codecov Report
@@ Coverage Diff @@
## master #475 +/- ##
==========================================
- Coverage 86.6% 86.58% -0.02%
==========================================
Files 7 7
Lines 1560 1558 -2
==========================================
- Hits 1351 1349 -2
Misses 120 120
Partials 89 89
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, but this changes I'm not sure does it work for programmatically value passing? I think we could add the test for it.
This change fix annoying {{.Host}} and {{.BasePath}} into json/yaml files. I have no clue what other tests you are suggesting to add. The issue was introduced
|
I've left some comments on issue itself. Anyway if you don't like it just refuse the PR. |
It’s ok for me. I would check later and add the tests if necessary. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Describe the PR
fix issue 474
fix issue 461
repair case tests
Relation issue
#474
#461
Additional context