Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support anonymous nested structure slice parsing #462

Merged
merged 6 commits into from
Jul 18, 2019

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Jul 18, 2019

Describe the PR
support anonymous nested structure slice parsing

Relation issue
#437

Additional context
none

@ubogdan ubogdan requested a review from easonlin404 July 18, 2019 09:44
@codecov-io
Copy link

codecov-io commented Jul 18, 2019

Codecov Report

Merging #462 into master will increase coverage by 0.11%.
The diff coverage is 92.59%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #462      +/-   ##
==========================================
+ Coverage   85.83%   85.94%   +0.11%     
==========================================
  Files           7        7              
  Lines        1468     1494      +26     
==========================================
+ Hits         1260     1284      +24     
- Misses        119      120       +1     
- Partials       89       90       +1
Impacted Files Coverage Δ
property.go 100% <100%> (ø) ⬆️
parser.go 81.05% <92%> (+0.28%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d8cb1c8...51d6c90. Read the comment docs.

@easonlin404 easonlin404 changed the title Fix issue 437 fix: support anonymous nested structure slice parsing Jul 18, 2019
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants