Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ability to set "schemes" programatically #438

Merged
merged 4 commits into from
Jul 8, 2019
Merged

feat: ability to set "schemes" programatically #438

merged 4 commits into from
Jul 8, 2019

Conversation

ubogdan
Copy link
Contributor

@ubogdan ubogdan commented Jul 7, 2019

Describe the PR
Ability to set "schemes" programatically

Additional context
PR for ISSUE: #433

@codecov-io
Copy link

codecov-io commented Jul 7, 2019

Codecov Report

Merging #438 into master will decrease coverage by 0.06%.
The diff coverage is 71.42%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #438      +/-   ##
==========================================
- Coverage   81.83%   81.77%   -0.07%     
==========================================
  Files           7        7              
  Lines        1448     1454       +6     
==========================================
+ Hits         1185     1189       +4     
- Misses        157      158       +1     
- Partials      106      107       +1
Impacted Files Coverage Δ
gen/gen.go 60% <71.42%> (+0.81%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e1fae5f...2e7397c. Read the comment docs.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you help add/or modify the example at README like https://github.com/swaggo/swag/edit/master/README.md#L167-L196 ?

@ubogdan
Copy link
Contributor Author

ubogdan commented Jul 8, 2019

Readme updated.

README.md Outdated Show resolved Hide resolved
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404 easonlin404 changed the title Feature: Ability to set "schemes" programatically feat: ability to set "schemes" programatically Jul 8, 2019
@easonlin404 easonlin404 merged commit 9fbf26c into swaggo:master Jul 8, 2019
@easonlin404
Copy link
Member

@ubogdan Thanks for your contributions. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants