Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: fail when searchDir contains no package #434

Merged
merged 2 commits into from
Jul 3, 2019
Merged

Conversation

easonlin404
Copy link
Member

fix #432

@easonlin404 easonlin404 added the bug label Jul 3, 2019
@codecov-io
Copy link

Codecov Report

Merging #434 into master will decrease coverage by 0.11%.
The diff coverage is 60%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #434      +/-   ##
==========================================
- Coverage   81.95%   81.83%   -0.12%     
==========================================
  Files           7        7              
  Lines        1441     1448       +7     
==========================================
+ Hits         1181     1185       +4     
- Misses        156      157       +1     
- Partials      104      106       +2
Impacted Files Coverage Δ
parser.go 79.36% <60%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 393e5cc...59e842f. Read the comment docs.

@easonlin404 easonlin404 merged commit 91ec3e6 into master Jul 3, 2019
@easonlin404 easonlin404 deleted the fixes-432 branch July 3, 2019 08:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fail when module contains no package
2 participants