Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add option to explicitly include or exclude third party dependencies #426

Merged
merged 1 commit into from
Jul 1, 2019

Conversation

Cloudzp
Copy link
Contributor

@Cloudzp Cloudzp commented Jun 28, 2019

Describe the PR
add option to explicitly include or exclude third party dependencies

Relation issue
#421

@codecov-io
Copy link

codecov-io commented Jun 28, 2019

Codecov Report

Merging #426 into master will decrease coverage by 0.8%.
The diff coverage is 20%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #426      +/-   ##
==========================================
- Coverage   82.76%   81.95%   -0.81%     
==========================================
  Files           7        7              
  Lines        1439     1441       +2     
==========================================
- Hits         1191     1181      -10     
- Misses        141      156      +15     
+ Partials      107      104       -3
Impacted Files Coverage Δ
parser.go 79.54% <0%> (-1.35%) ⬇️
gen/gen.go 59.18% <100%> (+0.85%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d2e27a2...33375db. Read the comment docs.

Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you help add this flag description at README?

@Cloudzp
Copy link
Contributor Author

Cloudzp commented Jul 1, 2019 via email

add new flag parseDependency description

add new flag parseDependency description
Copy link
Member

@easonlin404 easonlin404 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@easonlin404
Copy link
Member

easonlin404 commented Jul 1, 2019

We should release swag 1.6 asap that supports paring outside project dependencies, and add note that disabled by default.

@easonlin404 easonlin404 merged commit 593e936 into swaggo:master Jul 1, 2019
@Cloudzp Cloudzp deleted the bugfix_01 branch July 2, 2019 15:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants