Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix generic type that has more than 2 params with only one constraint type #1506

Merged
merged 2 commits into from
Mar 20, 2023

Conversation

sdghchj
Copy link
Member

@sdghchj sdghchj commented Mar 19, 2023

Describe the PR
fix generic type that has more than 2 params with only one constraint type.
Before, we have only onsidered generic type format like [x any, y any], but missed [x,y any].

Relation issue
#1490

@codecov
Copy link

codecov bot commented Mar 19, 2023

Codecov Report

Patch coverage: 92.30% and project coverage change: +0.03 🎉

Comparison is base (aa3e8d5) 85.14% compared to head (5ea11a0) 85.18%.

❗ Current head 5ea11a0 differs from pull request most recent head 2317cc4. Consider uploading reports for the commit 2317cc4 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1506      +/-   ##
==========================================
+ Coverage   85.14%   85.18%   +0.03%     
==========================================
  Files          19       19              
  Lines        3616     3637      +21     
==========================================
+ Hits         3079     3098      +19     
- Misses        459      460       +1     
- Partials       78       79       +1     
Impacted Files Coverage Δ
gen/gen.go 93.51% <ø> (ø)
field_parser.go 96.90% <33.33%> (-0.55%) ⬇️
generics.go 100.00% <100.00%> (ø)
operation.go 96.11% <100.00%> (+0.01%) ⬆️
parser.go 94.50% <100.00%> (+0.05%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ubogdan
Copy link
Contributor

ubogdan commented Mar 19, 2023

Could you add some unit tests to cover this change?

ubogdan
ubogdan previously approved these changes Mar 19, 2023
Signed-off-by: sdghchj <[email protected]>
@sdghchj
Copy link
Member Author

sdghchj commented Mar 20, 2023

@ubogdan added

@ubogdan
Copy link
Contributor

ubogdan commented Mar 20, 2023

@sdghchj let's get this merged and release a new version.

@ubogdan ubogdan merged commit 8445e75 into master Mar 20, 2023
@ubogdan ubogdan deleted the generic-fix2 branch March 20, 2023 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants