Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gocritic comment should match error bugfix. #1443

Merged
merged 3 commits into from
Jan 25, 2023

Conversation

onuragtas
Copy link
Contributor

Error;

gocritic check -enableAll ./...
./docs/docs.go:2:1: codegenComment: comment should match Code generated .* DO NOT EDIT. regexp
make: *** [critic] Error 1

This changes fix it.
Please approve pr.

hakanbaysal

This comment was marked as duplicate.

hakanbaysal
hakanbaysal previously approved these changes Jan 19, 2023
Copy link

@hakanbaysal hakanbaysal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this change. Thanks @onuragtas

gen/gen.go Outdated Show resolved Hide resolved
@ubogdan
Copy link
Contributor

ubogdan commented Jan 19, 2023

Also, please run the generator against the example folder .

@codecov
Copy link

codecov bot commented Jan 19, 2023

Codecov Report

Base: 85.14% // Head: 85.14% // No change to project coverage 👍

Coverage data is based on head (898bb4b) compared to base (00dd8cb).
Patch coverage: 100.00% of modified lines in pull request are covered.

❗ Current head 898bb4b differs from pull request most recent head 6e2c87c. Consider uploading reports for the commit 6e2c87c to get more accurate results

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1443   +/-   ##
=======================================
  Coverage   85.14%   85.14%           
=======================================
  Files          19       19           
  Lines        3616     3616           
=======================================
  Hits         3079     3079           
  Misses        459      459           
  Partials       78       78           
Impacted Files Coverage Δ
gen/gen.go 93.51% <ø> (ø)
packages.go 89.12% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants